Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkout: reserve a new order id if early place order has payment issues #330

Merged
merged 1 commit into from
Aug 10, 2021

Conversation

carstendietrich
Copy link
Member

If the payment provider enforces an early place order and the payment is then aborted we never renew the order id.

If the payment provider enforces an early place order and the payment is then aborted we never renew the order id.
@carstendietrich carstendietrich requested a review from tessig August 10, 2021 13:58
Copy link
Member

@tessig tessig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks ok.
we should perhaps rethink the whole order controller ;)

@carstendietrich carstendietrich merged commit e463595 into master Aug 10, 2021
@carstendietrich carstendietrich deleted the bugfix/early-place-order branch August 10, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants