cart: enhance shipping cost information and discount calculation #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carstendietrich
requested changes
Jul 14, 2021
cart/Readme.md
Outdated
| |-----------------------------------|------------------------------------------------------------------------------|-------------------------------------------------------------------| | ||
| | SubTotalGross() | Sum of items RowPriceGross | | | ||
| | SumRowTaxes() | List of the sum of the different RowTaxes | | | ||
| | SumTotalTaxAmount() | Sum of all applied item taxes | | |
There was a problem hiding this comment.
guess we should mention that this includes shipping taxes
cart/Readme.md
Outdated
| | Key | Desc | Math | | ||
| |-----------------------------------|------------------------------------------------------------------------------|-------------------------------------------------------------------| | ||
| | SubTotalGross() | Sum of items RowPriceGross | | | ||
| | SumRowTaxes() | List of the sum of the different RowTaxes | | |
There was a problem hiding this comment.
maybe mention here that this is only for cart items
cart/Readme.md
Outdated
| | SumGrandTotalWithGiftCards() | The final amount with the applied gift cards subtracted. If there are no gift cards, equal to GrandTotal() | GrandTotal() - SumAppliedGiftCards() | | ||
| | Key | Desc | Math | | ||
| |-----------------------------------|----------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------| | ||
| | GrandTotal() | The final amount that need to be paid by the customer (Gross) | SubTotalGross() + SumTotalDiscountAmount() + Sum(Totalitems) | |
There was a problem hiding this comment.
The math here is wrong I guess or at least not matching to the code
cart/Readme.md
Outdated
| | SumNonItemRelatedDiscountAmount() | | Sum of items NonItemRelatedDiscountAmount | | ||
| | SumItemRelatedDiscountAmount() | | Sum of items ItemRelatedDiscountAmount | | ||
| | Key | Desc | Math | | ||
| |-----------------------------------|------------------------------------------------------------------------------|-------------------------------------------------------------------| |
There was a problem hiding this comment.
delivery.GrandTotal() missing
CHANGELOG.md
Outdated
| @@ -8,13 +8,17 @@ | |||
| * Add new endpoint `DELETE /api/v1/cart/deliveries/items` to be able to remove all cart items from all deliveries but keeping delivery info and other cart data untouched | |||
| * Add new method `SumShippingGrossWithDiscounts` to the cart domain which returns gross shipping costs for the cart | |||
| * When using the `ItemSplitter` to split items in items with single qty (`SplitInSingleQtyItems`) the split discounts are reversed to make splitting the row total stable. | |||
| * **Breaking**: Delivery discount sum calculations `SumNonItemRelatedDiscountAmount`,`SumItemRelatedDiscountAmount` now take discount on shipping costs into account | |||
There was a problem hiding this comment.
SumTotalTaxAmount breaking as well now also with shipping
There was a problem hiding this comment.
SumTotalDiscountAmount breaking since also shipping discounts involved
There was a problem hiding this comment.
shippingItem.PriceGross() can be added as new, currently only in the GraphQL changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.