Support window icons on Wayland #2087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This syncs with Flatpak usage, allowing the use of a single desktop file name on all platform. (Flatpak is very opinionated.) This will be useful to set the desktop file name on the QApplication. Related to longturn#2019, longturn#984.
This gives us window icons on Wayland. Related to longturn#2019, longturn#984.
jwrober
approved these changes
Dec 25, 2023
Should I also rename the modpack installer desktop file to please the Flatpak gatekeepers? |
No it passed muster the first time. |
Ah we just renamed it to remove the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Wayland, window icons are taken from
.desktopfiles. This PR adds support for this.QApplicationI used the normal desktop file name for the modpack installer; Flatpak installs a different one.
The Flatpak manifest will need small changes to accommodate the renamed files.