Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The client cannot find its window icon #2019

Closed
lmoureaux opened this issue Aug 1, 2023 · 2 comments · Fixed by #2088
Closed

The client cannot find its window icon #2019

lmoureaux opened this issue Aug 1, 2023 · 2 comments · Fixed by #2088
Assignees
@jwrober
Labels
bug Something isn't working gui This issue requires changes to the user interface

Comments

@lmoureaux
Copy link
Contributor

Describe the bug

[critical] freeciv21-client (.../freeciv21/client/tileset/tilespec.cpp:1208) - Could not load gfx file "misc/freeciv21-client".

and the window icon is missing.

To Reproduce
Steps to reproduce the behavior:

  1. Start Freeciv21
  2. Look at the icon in the task manager
  3. A generic icon is used

Expected behavior

A shiny Freeciv21 icon is shown.

Platform and version (please complete the following information):

  • OS: Linux
  • Freeciv21 version: master

Additional context

The window icon doesn't work on Wayland for other reasons.
Solving #984 would also fix this issue.
@lmoureaux lmoureaux added bug Something isn't working gui This issue requires changes to the user interface labels Aug 1, 2023
@jwrober
Copy link
Collaborator

jwrober commented Aug 1, 2023 •
edited
Loading

This is fixed with these commits - fd9f828
153bea8

@jwrober jwrober closed this as completed Aug 1, 2023
@lmoureaux
Copy link
Contributor Author

Only if you install. If you run from the source folder without installing it doesn't have the file.

@lmoureaux lmoureaux reopened this Aug 1, 2023
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 25, 2023
@lmoureaux
Remove .client from the main desktop file name
e1ac6d7 
This syncs with Flatpak usage, allowing the use of a single desktop file name
on all platform. (Flatpak is very opinionated.) This will be useful to set the
desktop file name on the QApplication.

Related to longturn#2019, longturn#984.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 25, 2023
@lmoureaux
Set desktop file names in GUI executables
56b63f2 
This gives us window icons on Wayland.

Related to longturn#2019, longturn#984.
lmoureaux added a commit that referenced this issue Dec 26, 2023
@lmoureaux
Remove .client from the main desktop file name
ca5de9d 
This syncs with Flatpak usage, allowing the use of a single desktop file name
on all platform. (Flatpak is very opinionated.) This will be useful to set the
desktop file name on the QApplication.

Related to #2019, #984.
lmoureaux added a commit that referenced this issue Dec 26, 2023
@lmoureaux
Set desktop file names in GUI executables
b204f10 
This gives us window icons on Wayland.

Related to #2019, #984.
lmoureaux added a commit to lmoureaux/freeciv21 that referenced this issue Dec 26, 2023
@lmoureaux
Load window icons from a custom icon theme
ee56c33 
The window icons used to be set by the tileset. This allowed user-made tilesets
to override our branding and required loading tilesets before the first window
was shown.

This commit moves the app icons away from tilesets into a custom icon theme
(this should eventually be merged into the hicolor theme).

Closes longturn#984.
Closes longturn#2019.
@lmoureaux lmoureaux mentioned this issue Dec 26, 2023
Merged
jwrober pushed a commit that referenced this issue Dec 29, 2023
@lmoureaux @jwrober
Load window icons from a custom icon theme
e47752e 
The window icons used to be set by the tileset. This allowed user-made tilesets
to override our branding and required loading tilesets before the first window
was shown.

This commit moves the app icons away from tilesets into a custom icon theme
(this should eventually be merged into the hicolor theme).

Closes #984.
Closes #2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwrober jwrober

Labels
bug Something isn't working gui This issue requires changes to the user interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Load window icons from a custom icon theme lmoureaux/freeciv21
2 participants
@lmoureaux @jwrober