fix: return if not gst accounts in advance payment tax reversal #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: set document type as bill of supply for non-taxable items
fix: round other charges in e-Invoice
fix: set filter query for transporter and driver field in PR and PI
) * fix: update tds details in tax withholding category * fix: linters * fix: formatting * fix: update tds_details * fix: update fields and rates in tax withholding category * fix: changes as per review * fix: if condition * refactor: variable names, update tax category algo, etc * fix: run patch in post_install * chore: resolve conflicts --------- Co-authored-by: ljain112 <[email protected]>
…ilient-tech#1756) * fix: add support for gl repost for Purchase Invoice ITC Reversal * fix: process futher to update stock ledger only if required * fix: revert simplification of ineligible itc to fix repost item stock * test: repost accounting ledger correctly with itc ineligibility * refactor: check if debit entry is required before getting expense account * test: enable repost settings for purchase invoice * fix: repost purchases item valuation and its test cases
* test: test case to validate customize form * test: test case to validate customize form --------- Co-authored-by: Ninad Parikh <[email protected]>
…visibility (resilient-tech#1758) * fix(ux): field `ineligibility_reason` in purchase receipt for better visibility as virtual field * fix: run onload when initializing the class
chore: update version compatibility
* test: test case to validate customize form * test: test case to validate customize form * test: test case to validate old_doc is protected or not --------- Co-authored-by: Ninad Parikh <[email protected]>
…-tds fix: ignore mandatory if tds account is not found
…tory fix: ignore mandatory fields for onload of purchase receipt
…nce-payment test: create sales return for the invoice with advance payment
fix: remove validation for duplicate tax withholding category
fix: overseas category is always interstate
* fix: added 'Pending Cancellation' as new einvoice status * fix: add new einvoice_status as 'Pending Cancellation' * fix: add_Wrapper_function_in_method * fix: change status after changes in einvoice applicable date * fix: change gst settings * fix: remove exceptions from e_invoice_summary * fix: changes as per review * fix: changes as per review * fix: use company directly in get_e_invoice_applicability_date * fix: changes as per review --------- Co-authored-by: ljain112 <[email protected]>
* feat: gstr-1 filed log * fix: gstr-1 apis * fix: GSTR-1 Mapping * feat: GSTR-1 UI (resilient-tech#1910) * feat: make GSTR-1 page * fix: minor changes in data * wip: gstr_1 beta * wip: gstr-1 beta ui * fix: working UI with dummy data * refactor: public js folder structure * fix: setup base for building columns * chore: update demo data * fix: consistent keys for sub categories * style: dynmic name for `File` tab * fix: overlap count for nil-rated , non-gst and exempted invoices * test: test cases for `update item after submit` in Sales Order and Purchase Order (resilient-tech#1979) * fix: group tax values and amounts for invoice print formats * fix: missing gst amounts in hsn json * chore: update compatible version * chore: use similar color for all number cards * fix: add overlaping invoice count summary to overview * fix: group overview in GST sales register beta by category (resilient-tech#2002) * fix: group overview in GST sales register beta by category * fix: better way to override datatable totals * chore: mapped data for gstr1 * fix: setup columns for gstr 1 beta * fix: add totals row for the summary * fix(minor): row width and checkbox for datatable * wip: category and sub-category filtering * fix: changes as per review * fix: validate for cess non-advol (resilient-tech#2009) * fix: validate for cess non-advol * fix: remove duplicate code * fix: changes as per view * chore: fix type, less nesting --------- Co-authored-by: ljain112 <[email protected]> * test: test cases for gst sales register beta report (resilient-tech#1965) * test: test cases for gst sales register beta report * fix: linters and item_code * fix: remove gst_treatement and posting date while creating invoices * fix: remove gst_treatement and posting date while creating invoices * fix: modified test cases * test: super setup to cleanup data post tests * refactor: test cases for sales register and modified required orderby in sales register beta report * fix: test cases and utility function for appending items in sales invoice * test: update similar treatment for original test cases * test: modified test output for overview --------- * test: test-cases for regional_overrides (resilient-tech#2006) * fix: test-cases for regional_overrides * refactor: test case placement and only required test cases --------- Co-authored-by: Smit Vora <[email protected]> * fix(minor): better way to override totals in gst sales beta report (resilient-tech#2022) * fix: uom as per gst (resilient-tech#2019) * fix: uom as per gst * chore: refactor and wrap original function --------- * refactor: seperate gstr_1 utilities * refactor: commanify gstr_utils and make gstr_2 independent * fix: prepare mapped data for hsn summary * fix: added document issued summary in mapped data * fix: reverse charge as "Y" or "N" * style: basic tree view for summary * fix: changed variable name --------- Co-authored-by: Smit Vora <[email protected]> Co-authored-by: Abdeali Chharchhodawala <[email protected]> Co-authored-by: priyanshshah2442 <[email protected]> Co-authored-by: Priyansh Shah <[email protected]> Co-authored-by: Smit Vora <[email protected]> Co-authored-by: Sanket322 <[email protected]> Co-authored-by: ljain112 <[email protected]> * feat: gstr-1 filed log (resilient-tech#2034) * refactor: bring all puzzles together * style: tree-view spacing * fix(ui): expand datatable upto borders * style: improvment of datatable * fix(ui): setup listeners * fix: gst settings for gstr-1 * fix: don't sub-categorise nil exempt and non-gst * fix: nil expempt data for js and trial data * fix: variable display of data based on status of return and gst settings * fix: OTP workflow for gstr-1 beta to authenticate APIs * chore: updated comments * fix: return status API integration * fix: gstr-1 mapping refactor * fix: download APIs setup * fix: mapping of data for AT and TXP * fix: tuple key changed to f-string * fix: tuple keys converted to string in gstr-1 json mapping * fix: working data pieces * fix: month and quarter depending on gst settings * fix: transaction type for all invoices * fix: summarize filed data * fix: no of records in summarize filed data * fix: gstr-1 json map refactor and guess customer name * chore: update comments, minor refactor in js * fix: reconcile books and gov data * fix: mapped-data data format refactor * fix: reconcile books vs returns * chore: cleanup unused page * fix: summarize data * fix: add supecom category * fix: totals for gstr-1 summary * fix: month or quarter options as per selected year * fix: better reconciliation and summarization * fix: minor changes to date selection * fix: refactor columns and consistent categories * fix: supecom mapping and format date * fix: working report with actual data * wip: gst ledger difference * fix: compute index in HSN and DOC_ISSUE Summary while converting to gov json * fix: fix e-Invoice tab * fix: difference in output gst ledger , collapse and expand button , computed on * fix: minor changes while testing (resilient-tech#19) * fix: e-Invoice data => unfiled data * fix(ux): correct totals for books summary with missing records * fix: subtitle for tabs * fix: detail view for reconcile data * refactorr: gstr_1 reconcile html template * fix: output gst ledger called multiple times * fix: changes to ledger data, etc * fix: summarize return-summary data * fix: summarize returns data with amendments * wip: endpoint for json export with options * fix: round books value, default blank table message * fix: changes as per review * fix: check gstr-1 filed upto and review js * fix: highlight difference if there * fix: validate and update latest data * refactor: class name, circular import * chore: update todos * fix: compute item index while converting to gov json format * fix: creation time for the report * fix: recompute books data * fix: download excel for books data * fix: download gstr-1 json * fix: gstr-1 upload errors resolved * fix: ignore str in json generation * fix: load data after all existing requests are complete * fix: update todos, show report from filed log * fix: action mark as filed * fix: generate summary for apis disabled * fix: download reconcile excel and refactor download books excel * fix: download json causing errror * fix: excel headers as per review * fix: colour for header and data * fix: download filed excel --------- Co-authored-by: Abdeali Chharchhodawala <[email protected]> Co-authored-by: Vishakh Desai <[email protected]> Co-authored-by: priyanshshah2442 <[email protected]> * fix: file naming and sheet naming * fix: Sheet naming as per mapping * fix: changes required to make it work * fix: excel column widths * fix: width for specific column in books and recncile excel download * fix: export gstr-1 excel * fix: as per review * fix: default formatting changes in excel format * fix: excel-export refactor * fix: don't send ecommerce gstin info to gov in regular sections * fix: b2b invoice types and enum * fix: refactor aggregate_invoices in NilRated GSTR-1 Mapping * fix: delete flag instead of zero values to handle missing in books * fix: check for production api's enabled for gstr-1 * refactor: file and code blocks restructuring * refactor: indentation to spaces * fix: remove unrequired data * fix: fixed failing test cases and re-arranged fields in Gov excel export as per Gov format * fix: set flag for otp_requested * fix: default permissions and update mark as filed * fix: save gstr1 filed upto in gstin doc * fix: minor codacy issues * fix: semgrep rules * fix: more fixes for codacy * refactor: gstr-1 generation and summarization * fix: correct empty state text * fix: default frequency to monthly * fix: readonly fields for filed log * chore: correct function name * refactor: enum names * refactor: data export and comminify utilities * refactor: common columns for reconcile * chore: linters * fix: ecommerce data summary conversion * fix: fallback for legacy summary data. * fix: process additional returns information after commit * fix: show gstr_1 beta alert on existing report * refactor: gstr-1 beta js * fix: codacy issues * chore: comments and todos * fix: gstr-1 json map doc-string added * fix: consistent data conversion, brief comments * fix: buttons based on API status * fix: modified docstring in gstr_1_json_map and fixed test cases * fix: non-mandatory fields in backend (single doctype), year options set dynamically * chore: formatting changes * chore: mark fields as mandatory * fix: return filed upto from db * fix: test cases and update ignored categories for overview * fix: re-compute if files are missing * fix: support delete permissions for beta * fix: changes as per review * fix: correct data computation for nil exempt * fix: show aggregated data for filing * refactor: renamed to GSTR-1 log * fix: minor enhancements to ui * fix: load normalized data in download_gstr1_json and fixed test cases * fix: support dynamic filters for detailed view * fix: disabled detail view * fix: ignore tax rate when getting difference * fix: changes as per review * fix: save aggregated data in books data * fix: delete unfiled files after return is filed * fix: update books json after aggregate data * fix: back button setup for detailed view * fix: aggregation, Inter vs Intra based on company gstin * fix: export positive values for select sections * chore: remove print statement * fix: b2cs data processing for books excel consistently * test: rename variable in test case * fix: json export, upload, sync test * fix: show only required columns in details view * fix: update dashboard for other report --------- Co-authored-by: Vishakh Desai <[email protected]> Co-authored-by: Divyam Mistry <[email protected]> Co-authored-by: Abdeali Chharchhodawala <[email protected]> Co-authored-by: priyanshshah2442 <[email protected]> Co-authored-by: Priyansh Shah <[email protected]> Co-authored-by: Sanket322 <[email protected]> Co-authored-by: ljain112 <[email protected]>
chore: Update conditions
fix: round all value fields for gstr-1 json
…tatus fix: correct upload status for GSTR-1 books
…e_invoice-with-boe fix: do not include exports without payment Purchase Invoices in GSTR3b.
fix: positive values for cdnr in gstr-1
feat: section to report e-commerce sale through GSTR-1
fix: `DoesNotExistError` while processing return info
…id-refactor fix: GST Transporter ID Refactor
fix(ux): show missing creds message only where relevant
* fix: changed gst tax invoice print format * fix: give css to erpnext elements * fix: more scalable design * fix: minor changes as per review * fix: style company_details and separate div * fix: changing style in heading * fix: created doctype for print format * fix: added new tab in company * fix: add data field for image url * fix: update minor html * fix: changes as per discussion * fix: changes as per review * chore: rename fields --------- Co-authored-by: Smit Vora <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://support.frappe.io/app/hd-ticket/17700