Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct upload status for GSTR-1 books #2226

Merged
merged 2 commits into from
Jun 9, 2024

Conversation

vorasmit
Copy link
Member

@vorasmit vorasmit commented Jun 9, 2024

No description provided.

@vorasmit vorasmit marked this pull request as ready for review June 9, 2024 10:06
Copy link

codecov bot commented Jun 9, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes missing coverage. Please review.

Project coverage is 61.40%. Comparing base (c191871) to head (97595c7).

Files Patch % Lines
...nce/gst_india/doctype/gst_settings/gst_settings.py 20.00% 8 Missing ⚠️
...pliance/gst_india/doctype/gstr_1_log/gstr_1_log.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2226      +/-   ##
===========================================
- Coverage    61.45%   61.40%   -0.05%     
===========================================
  Files          111      111              
  Lines        10674    10684      +10     
===========================================
+ Hits          6560     6561       +1     
- Misses        4114     4123       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vorasmit vorasmit merged commit 6cdf314 into resilient-tech:develop Jun 9, 2024
10 of 12 checks passed
@vorasmit vorasmit deleted the correct-upload-status branch June 9, 2024 14:40
vorasmit added a commit that referenced this pull request Jun 9, 2024
…tfix/pr-2226

fix: correct upload status for GSTR-1 books (backport #2226)
vorasmit added a commit that referenced this pull request Jun 9, 2024
…tfix/pr-2226

fix: correct upload status for GSTR-1 books (backport #2226)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant