Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: GST Transporter ID Refactor #2198

Merged
merged 8 commits into from
Jun 18, 2024
Merged

fix: GST Transporter ID Refactor #2198

merged 8 commits into from
Jun 18, 2024

Conversation

vishakhdesai
Copy link
Contributor

No description provided.

@vishakhdesai vishakhdesai force-pushed the transporter-id-refactor branch from 68d4a16 to 0fc37d4 Compare May 30, 2024 06:30
@codecov Codecov
Copy link

codecov bot commented May 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 50.44248% with 56 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (b093db1) to head (d842fb3).

Files Patch % Lines
india_compliance/gst_india/utils/gstin_info.py 33.33% 30 Missing ⚠️
india_compliance/gst_india/doctype/gstin/gstin.py 61.53% 20 Missing ⚠️
...nce/gst_india/doctype/gst_settings/gst_settings.py 57.14% 6 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #2198      +/-   ##
===========================================
- Coverage    61.22%   61.02%   -0.20%     
===========================================
  Files          111      111              
  Lines        10739    10767      +28     
===========================================
- Hits          6575     6571       -4     
- Misses        4164     4196      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vishakhdesai vishakhdesai force-pushed the transporter-id-refactor branch from 088fb0b to 3f2a83b Compare May 30, 2024 07:18
@vishakhdesai vishakhdesai marked this pull request as ready for review May 31, 2024 06:28
@ljain112 ljain112 linked an issue Jun 13, 2024 that may be closed by this pull request
Inconsistency with GST Transporter ID #2072
Closed
@vorasmit vorasmit merged commit 2a4888b into resilient-tech:develop Jun 18, 2024
10 of 12 checks passed
This was referenced Jun 18, 2024
Merged
Merged
mergify bot added a commit that referenced this pull request Jun 18, 2024
@mergify
Merge pull request #2258 from resilient-tech/mergify/bp/version-15-ho…
452b6a9 
…tfix/pr-2198

fix: GST Transporter ID Refactor (backport #2198)
mergify bot added a commit that referenced this pull request Jun 18, 2024
@mergify
Merge pull request #2257 from resilient-tech/mergify/bp/version-14-ho…
795a84f 
…tfix/pr-2198

fix: GST Transporter ID Refactor (backport #2198)
@vorasmit vorasmit mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljain112 ljain112 ljain112 left review comments

@vorasmit vorasmit vorasmit left review comments

Assignees
No one assigned
Labels
backport version-14-hotfix backport version-15-hotfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistency with GST Transporter ID
3 participants
@vishakhdesai @vorasmit @ljain112