improved language switching, fixed transparent navigation bar bug #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iferencak
changed the title
3 tasks
|
CURRENT-TEST-SUCCESS-1598 |
kcw-grunt
suggested changes
Jan 14, 2023
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> |
There was a problem hiding this comment.
Thought I .gitignored xcshareddata? @Iferencak . Is this a new setting? Should I migrate with it? Whats the benefit?
There was a problem hiding this comment.
Honestly I'm not sure how this got tracked.. I didn't touch .gitignore 🤷
| @@ -10,6 +10,16 @@ class AppDelegate: UIResponder, UIApplicationDelegate { | |||
|
|
|||
| func application(_ application: UIApplication, didFinishLaunchingWithOptions _: [UIApplicationLaunchOptionsKey: Any]?) -> Bool | |||
| { | |||
| UINavigationBar.appearance().tintColor = .darkText | |||
| let initialLanguage = UserDefaults.selectedLanguage | ||
| XCTAssertEqual(initialLanguage, "en") | ||
|
|
||
| let spannish = "es" |
There was a problem hiding this comment.
Microsopic nit 🔬 spannish should be spanish
| import Foundation | ||
|
|
||
| var _bundle: UInt8 = 0 | ||
|
|
There was a problem hiding this comment.
I love this solution. If I understand correctly, BundleEx does the heavy lifting of converting all the strings to the chosen language in a DQ? Its quite smooth
Only thing is I generally prefer guard let rather than forced unwrap.
Can we do :
guard let bundle = Bundle(path: Bundle.main.path(forResource: temp, ofType: "lproj") else {
LWAnalytics.logEvent(itemName: ._20200112_ERR)
return
}
Maybe it will never be called but it will help us sleep a little better.
There was a problem hiding this comment.
Sure thing, looks like i missed it after I finished prototyping. On it.
| class LanguageSelectionViewController: UITableViewController { | ||
| let viewModel = LanguageSelectionViewModel() | ||
|
|
||
| var titleLabel: UILabel! |
There was a problem hiding this comment.
🥲
Not really into force unwrap....it's hidden poison.
Why not just :
var titleLabel = UILabel()
There was a problem hiding this comment.
I agree completely, I hate force unwraping, sry. 😱
| self.updateTimer = nil | ||
| } | ||
|
|
||
| @objc | ||
| func languageChanged() { |
|
CURRENT-TEST-SUCCESS-1600 |
- BartyCrouch has a bug where the NSLocalizaedString makes extractLocStrings fail. The workaround is detailed here: https://github.com/FlineDev/BartyCrouch#exclude-specific-views--nslocalizedstrings-from-localization
- BC and extractLocStrings did not get along Barty Crouch have an open issue as extractLocStrings is deprecated by Apple so the script is barfing. The notes on the issue are here: FlineDev/BartyCrouch#135 (comment) The other issue was the NSNotificationCenter was not happy and the work around was: - deinit and remove observers for the new post - remove the assertFailure (which I added) and replaced it with an LWAnalytics error event - added a Error NSlog message - also moved all the NSN to its own file NSNExtension
kcw-grunt
approved these changes
Jan 17, 2023
|
CURRENT-TEST-SUCCESS-1602 |
- polished language view
kcw-grunt
added a commit
that referenced
this pull request
Jan 26, 2023
* 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🚧[Techdebt] Firebase polish 121 (#139) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * build bump -clean up strings file - Udpated to iOS 14.0 as a target https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/ * Removed cruft * Updated the Firebase constants - changed it to lowercase * updated links * fixed constants -build bump * reemvoed conflict tags * Mark unused code (#147) * Added and modified a ruby script that shows a warining if a class, function or variable is not used * Fixed static function partnersDataArray * Updated build number * changed the urtl - change the deployment target * Retired old https server code (#154) * #148 Fixed a crash that appeared when the users wallet was aout of sync and a prompt neaded to appear * Removed dispatchqueue.async that was used for testing * 🚀[Release v3.10.1] Merge into Develop (#162) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🚧[Techdebt] Firebase polish 121 (#139) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * build bump -clean up strings file - Udpated to iOS 14.0 as a target https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/ * Removed cruft * Updated the Firebase constants - changed it to lowercase * updated links * fixed constants -build bump * Mark unused code (#147) * Added and modified a ruby script that shows a warining if a class, function or variable is not used * Fixed static function partnersDataArray * Updated build number * build bump * clean up duplicate scripts * readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]"; -bumped the version and build to test Bitrise * fixed today extension version and build number * fixed coding norm (space after colon) - fixed Turkish - Italian mixup - version bump * Add SwiftFormat to the codebase (#159) * Added SwiftFormat to the run scripts * Removed --elseOnSameLine from rules as it is on by default * Added --disable enumNamespaces rule * Using SwiftFormat to auto-format current code * Removed --allman rule * 🚀[Release v3.10.1] Merge into Develop (#162) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🚧[Techdebt] Firebase polish 121 (#139) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * build bump -clean up strings file - Udpated to iOS 14.0 as a target https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/ * Removed cruft * Updated the Firebase constants - changed it to lowercase * updated links * fixed constants -build bump * Mark unused code (#147) * Added and modified a ruby script that shows a warining if a class, function or variable is not used * Fixed static function partnersDataArray * Updated build number * build bump * clean up duplicate scripts * readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]"; -bumped the version and build to test Bitrise * fixed today extension version and build number * fixed coding norm (space after colon) - fixed Turkish - Italian mixup - version bump * Added SwiftFormat to the run scripts * Removed --elseOnSameLine from rules as it is on by default * Added --disable enumNamespaces rule * Using SwiftFormat to auto-format current code * Removed --allman rule * PartnerData auto-format * Added marking of unused code back to runscripts * Delete PubtoPrivate.yml * Delete sync-mirror.yml Co-authored-by: Kerry Washington <[email protected]> * 🤬[Techdebt] #167 add custom user agent++ (#168) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🚧[Techdebt] Firebase polish 121 (#139) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * build bump -clean up strings file - Udpated to iOS 14.0 as a target https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/ * Removed cruft * Updated the Firebase constants - changed it to lowercase * updated links * fixed constants -build bump * Mark unused code (#147) * Added and modified a ruby script that shows a warining if a class, function or variable is not used * Fixed static function partnersDataArray * Updated build number * changed the urtl - change the deployment target * removed staging server url normalizing to the prod server only * aded small test - build bump * Retired old https server code (#154) * Updated * 🚀[Release v3.10.1] Merge into Develop (#162) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🚧[Techdebt] Firebase polish 121 (#139) * 🚀[Release v3.10.0] Merge into Main (#136) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * Create sync-mirror.yml * Changed the clone sig * Update sync-mirror.yml - added sync branches and tags * Update sync-mirror.yml refactor * Update sync-mirror.yml fixed uname * Update sync-mirror.yml * Update sync-mirror.yml * Create PubtoPrivate.yml * Update sync-mirror.yml * 🚀[Release v3.10.0] Merge into Develop (#135) * 🦺[Techdebt] fix firebase (#115) * Update firebase config auto clean up strings - version bump - Commented out debug FB file * Checked the version is sending FB data - bump build number * 🥳[Techdebt] relayout address view controller (#120) * Successfully placed in UIHosting Address Updated the strings file * Added event * added delay - used for animating U Domain * Added function of subviews in SendViewController Layout is updated * Adding the function to the send Cleaned up and wired up Cells - UD View/Model - Send Address View/Model Reset the amount Label in SendViewController * Refactored SendButton - Using UIHostingViewController * Successfully send LTC -WIP: fix white space * Refactored the layout of the send button * buiid bump (#125) * [Techdebt] ci cd refactor (#132) * Removed flaky tests * build bump * build bump * removed unused file - build bump * build bump * fixed scan QR (#130) * fixed scan QR * update gitignore * Feature/add bitrefill new (#134) * Added llocalView - added bitrefill - basic function is available - build bump * bump * added basic web widget * updated logo * build bump * changed the Bitrefill link - build bump * pre-bump version - to get a binary to TestFlight * build bump * build bump again * Clean up background * build bump * build bump -clean up strings file - Udpated to iOS 14.0 as a target https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/ * Removed cruft * Updated the Firebase constants - changed it to lowercase * updated links * fixed constants -build bump * Mark unused code (#147) * Added and modified a ruby script that shows a warining if a class, function or variable is not used * Fixed static function partnersDataArray * Updated build number * build bump * clean up duplicate scripts * readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]"; -bumped the version and build to test Bitrise * fixed today extension version and build number * fixed coding norm (space after colon) - fixed Turkish - Italian mixup - version bump * added custom var * build bump * Add codesigndoc ignore * Added Swift Packages to the project - Closes : #156 * Removed pods * Added Litewallet PartnerAPI to project * SUCCESS! - Added PartnerAPI as a Submodule * Rebase from SwiftFormat * Update .gitignore * Removed submodule * resetting add the submodule * updated config * Removed PartnerAPI #170 Removed references to the LitewalletPartnerAPI lib - Compiled the app - Added LitecoinCard View for CardView - Added CardWebViewController - Deleted unused views and viewModels * change build number * Rmeoved all LitecoinCard Tests * build bump * Failed Test for Bitrise CI * Unbroken tests * small change build bump * another build bump * build again * build bump * yet again bump * small change * matching build number with bitrise run * nonsense change * Fixed the UDSystem Error issues - removed commented out PartnerAPI Code Co-authored-by: Iferencak <[email protected]> * Delete sync-mirror.yml (#176) * Delete push-to-release-email.yml (#175) * Delete github-actions.yml (#174) deleting unused workflow * Update README.md (#173) Added a reminder to cleanup Old workflow runs * improved language switching, fixed transparent navigation bar bug (#179) * Improved language selection * Fixed transaction completion localization, removed force unwrapings, fixing typos * autoformat - BartyCrouch has a bug where the NSLocalizaedString makes extractLocStrings fail. The workaround is detailed here: https://github.com/FlineDev/BartyCrouch#exclude-specific-views--nslocalizedstrings-from-localization * resolved flaky compile issue - BC and extractLocStrings did not get along Barty Crouch have an open issue as extractLocStrings is deprecated by Apple so the script is barfing. The notes on the issue are here: FlineDev/BartyCrouch#135 (comment) The other issue was the NSNotificationCenter was not happy and the work around was: - deinit and remove observers for the new post - remove the assertFailure (which I added) and replaced it with an LWAnalytics error event - added a Error NSlog message - also moved all the NSN to its own file NSNExtension * bump version - polished language view Co-authored-by: kcw-grunt <[email protected]> * version bump - build bump * build bump to trigger bitrise * bump for matching bitrise * Fixed a crash when force trying to get a creation date of unexisting file (#188) Co-authored-by: Iferencak <[email protected]>
kcw-grunt
added a commit
that referenced
this pull request
Apr 2, 2024
* fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> * [Bugfix] Replace the LF Support View (#159) * Moved the LF Cell from Send. - BartyCrouch linted the stigns files. * Updated the LF Support location - Reset the localiaztion language to ‘Customer support’ - Add the dismissal actions * [Bugfix] Fix buy tab: Simplex urls (#157) * Updated the url to new servers * Linted the Localized strings * Setup url constants * updated pk file status * Updated per PR review comments * fixed naming of the url variable * [Merge v2.8.3] into Develop (#169) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Master (#153) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * version bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Feature Issue 154] Adding Unstoppable Domains functionality (#155) * Added UD to Podfile - Stubbed out the view, viewModel and the test class for UD * [UI Polish] Added images and localized strings - Added more of strings and UD structure - Trimmed images to resize for button - Added localized strings for placeholder * Updated UnstoppableDomainsView and Model details - Added DEV notes script - Adjusted Previews by unchecking the `build install only` * Added more tests - UnstoppableDomains View Model tests - SupportLitecoinFoundationViewModel tests * reformatted code in new SwiftUI views and viewModels * Added UD action to the SendViewController * Updated project * Updated localized UD Placeholder * Setup API keys * removed pk file * Changed the localizations related to UD - Added ‘Or’ label - Added UD placeholder text - Changed the LTC address placeholder text * Added in the Or and relayout of the button - Added Partner layout view for UD and Simplex * Resolved code review comments - Update the localizations - Refactored the UD shared instance (singleton) to retain throguh the call - Added timing probes * revert to current version * reformatted the Support LF view strings * Remove Test Playground. * Removed unused SocialView and ViewModel * Improved resolution - Added a Dispatch and ‘exit’ when address is found sooner than 12 secs. Much better experience for the user. * Added infura * Resolved review comments * Rewrote copy for “Enter a Litecoin address” * Fix some trivial conflict markers (#177) * [Bugfix] Upgrade the business logic for Unstoppable Domains (#179) * Fix some triival conflict markers * Added test to button once the UD string meets a minimum length * Clears address text field when Lookup button is pressed * Set the background color of the AlertToast * Locailization of the alert language * move logic to release the first responder * per review notes * [Feature] Litecoin card v1 (#180) * [Litecoin Card] Progress Step 1 - Major work: litecoin-card TabBarView refactor - Updated UIColor for Color - SwiftUI preview devices - Working out the Nav polish - Fixed hard-coded UD lookup label with proper localizations - Commented out BitId * [Litecoin Card] Progress Step 2 - Added more localizations - Rebuilding registration view need to add keyboard - Fixed the animation for the card view - Fixed Alert name collisions to the SimplexAlert * [Litecoin Card] Progress Step 3 - Added Login views and localizations - Added partnerAPI Swift Package - Layout the registration view - Add more localizations - BUGFIX: Image missing in this branch. * [Litecoin Card] Progress Step 4 More localizations Added data Validators Final Polish for Registration View Registration View Modal wiring works * [Litecoin Card] Progress Step 5 Register works to the model Login is working Added animation for Login/Logout Login and Loogut working Added localizations More localizations * [Litecoin Card] RC 1 polishes Communcations polishing + dev cleanup Polishing the RegistrationView layout Fixed bug: https://github.com/litecoin-foundation/loafwallet-ios/issues/175 * [Litecoin Card] RC2: removed defunct script * per review comments - Ar files removal - Cleanup localizable - Removed Ar.proj files - Removed empty class - Added all Validation localization framework - Added localizations of the validations - Refactored per review notes * Bugfix- login message Added failure message localizations * [Merge v3.0.0] into Develop (#184) * version bump * Added some tests * Refactored the login logic - Used the status of the binding to change the UI * Added combined logic of the email and password fields to enable login button Reference @losh11 comment: `The cards login now gives a good login failed alert. However I think the login button should be disabled until the text in the email input is validated as email format.` * build bump * [HOTFIX] hide litecoin card (#192) * [Merge v3.0.0] into Master (#183) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> * [Bugfix] Replace the LF Support View (#159) * Moved the LF Cell from Send. - BartyCrouch linted the stigns files. * Updated the LF Support location - Reset the localiaztion language to ‘Customer support’ - Add the dismissal actions * [Bugfix] Fix buy tab: Simplex urls (#157) * Updated the url to new servers * Linted the Localized strings * Setup url constants * updated pk file status * Updated per PR review comments * fixed naming of the url variable * [Merge v2.8.3] into Develop (#169) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * [Release v2.8.2] Merge into Master (#153) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release v2.8.2] Merge into Develop ## Release Notes: v2.8.2 (1) This release is due to a requirement to App Store to remove references to donations. In it’s replacement, a reference to the Litecoin Foundation support page where the user can elect to send LTC if they so choose. - [Warmfix] Issue:146 Remove direct donation: support litecoin foundati… ## Other Improvements - Fix crash in Amount formatter (#140) - [Bugfix] Renamed enum from State (#147) (#150) ## Bugfixes - Renaming the enum caused a conflict with SwiftUI @State ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Hotfix Increment -Updated to allow upload to App Store * build number change * fixed conflicts Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * version bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Feature Issue 154] Adding Unstoppable Domains functionality (#155) * Added UD to Podfile - Stubbed out the view, viewModel and the test class for UD * [UI Polish] Added images and localized strings - Added more of strings and UD structure - Trimmed images to resize for button - Added localized strings for placeholder * Updated UnstoppableDomainsView and Model details - Added DEV notes script - Adjusted Previews by unchecking the `build install only` * Added more tests - UnstoppableDomains View Model tests - SupportLitecoinFoundationViewModel tests * reformatted code in new SwiftUI views and viewModels * Added UD action to the SendViewController * Updated project * Updated localized UD Placeholder * Setup API keys * removed pk file * Changed the localizations related to UD - Added ‘Or’ label - Added UD placeholder text - Changed the LTC address placeholder text * Added in the Or and relayout of the button - Added Partner layout view for UD and Simplex * Resolved code review comments - Update the localizations - Refactored the UD shared instance (singleton) to retain throguh the call - Added timing probes * revert to current version * reformatted the Support LF view strings * Remove Test Playground. * Removed unused SocialView and ViewModel * Improved resolution - Added a Dispatch and ‘exit’ when address is found sooner than 12 secs. Much better experience for the user. * Added infura * Resolved review comments * Rewrote copy for “Enter a Litecoin address” * Fix some trivial conflict markers (#177) * [Bugfix] Upgrade the business logic for Unstoppable Domains (#179) * Fix some triival conflict markers * Added test to button once the UD string meets a minimum length * Clears address text field when Lookup button is pressed * Set the background color of the AlertToast * Locailization of the alert language * move logic to release the first responder * per review notes * [Feature] Litecoin card v1 (#180) * [Litecoin Card] Progress Step 1 - Major work: litecoin-card TabBarView refactor - Updated UIColor for Color - SwiftUI preview devices - Working out the Nav polish - Fixed hard-coded UD lookup label with proper localizations - Commented out BitId * [Litecoin Card] Progress Step 2 - Added more localizations - Rebuilding registration view need to add keyboard - Fixed the animation for the card view - Fixed Alert name collisions to the SimplexAlert * [Litecoin Card] Progress Step 3 - Added Login views and localizations - Added partnerAPI Swift Package - Layout the registration view - Add more localizations - BUGFIX: Image missing in this branch. * [Litecoin Card] Progress Step 4 More localizations Added data Validators Final Polish for Registration View Registration View Modal wiring works * [Litecoin Card] Progress Step 5 Register works to the model Login is working Added animation for Login/Logout Login and Loogut working Added localizations More localizations * [Litecoin Card] RC 1 polishes Communcations polishing + dev cleanup Polishing the RegistrationView layout Fixed bug: https://github.com/litecoin-foundation/loafwallet-ios/issues/175 * [Litecoin Card] RC2: removed defunct script * per review comments - Ar files removal - Cleanup localizable - Removed Ar.proj files - Removed empty class - Added all Validation localization framework - Added localizations of the validations - Refactored per review notes * Bugfix- login message Added failure message localizations * version bump * Added some tests * Refactored the login logic - Used the status of the binding to change the UI * Added combined logic of the email and password fields to enable login button Reference @losh11 comment: `The cards login now gives a good login failed alert. However I think the login button should be disabled until the text in the email input is validated as email format.` * build bump Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * Hide Card Tab * added comments for v1 Co-authored-by: Mohamed Barry <[email protected]> Co-authored-by: Nikolay Spassov <[email protected]> * [Bugfix]UD resolved address / got callback (#193) * Fixed bug: resolved address / got callback - Added a dispatch group - Fixed the bug by adding wait to the group from (@JohnnyJumper) - Refactored partner plist * removed cruft * polish UD model * v3.0.1 Card Hidden - found hidden code… * Resolved review comment - polished the address send label * removed unused code - clean comments * [Merge into Develop] Release v3.1.1 (#195) * [Merge v3.0.0] into Master (#183) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * Develop - Release/v2.8.0 (#132) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that has never been called - Added in 2016 - This is not supported currently * Change email addresses Also added feedback and support emails. * Added HTML for support email Fixed bitcoin references * Removed empty UITests * bump build number * updated html to be for iPhone only * Fix podfile and build version * Revert "[Bugfix] Cleared Simplex (#126)" This reverts commit 154eb4fbbe71b4ff1a2323dd316bf7b6783c3b0a. * bump build number Co-authored-by: Mohamed Barry <[email protected]> * Fix crash in Amount formatter (#140) * 🦺 [Tech Debt] Update Podfile and Refactor build process (#144) * Update Podfile - Set mimum value of iOS 13 - Removed unused SwiftyJSON - Removed unused Watch Scheme - re-added xcscheme - removed non-used code - added status badge in README * removed the podfile target force * added SPM .build folder exclusion in gitignore * [Bugfix] Renamed enum from State (#147) * Renamed enum from State ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` * Toggled iOS version 13 * Revert "[Bugfix] Renamed enum from State (#147)" (#150) This reverts commit ea8293b5c7f206706942416a1d7d9b139926fa97. * [Warmfix] Issue:146 Remove direct donation: support litecoin foundation (#151) * Prepared the code for differnt Cell / Remove Donation Code - Updated localized strings file(s) - Removed old Donate files - Updated SendVIewController * Resolved the previous conflicts - Added in SupportLitecoinFoundation SwiftUI view and model - Working in the basic functionality of the new Support Litecoin Foundation view * Worked in the vars of SupportLitecoinFoundation view * Removed Donation code * Set a URL for the support LTC address * Add new WebKit view and supporting code * Adjusted height constants in the nightmare scenario of the SendCell -There is a nasty sandwich of ViewControllers where SwiftUI should be used. - This needs to be simplified # Conflicts: # loafwallet/src/ViewControllers/RootModals/SendViewController.swift * Added new MVVM Views and ViewModels - Adding more SwiftUI code * Refactored and stubbed out tests * version bump * Renamed enum from State to ReduxState ## Problem The original design of Breadwallet (Loafwallet) used a SimpleRedux architecture which maanged the State in an unsual (yet effective) way. Within that design ‘state’ was managed by an enum named “State” This was fine until SwiftUI and Combine where there is now a name collision since @State is referring to the SwfitUI attribute. ## Approach While redesiging the app would be ideal, the reality is this needs to be fixed as soon as possible because Litewallet is now using SwiftUI. Steps to fix the problem: - [ ] Renamed variable from `State` to `ReduxState` using Xcode Refactor: Rename * Cleaned up Localized strings file * Added review fixes - Added CGFloat multiplier in padding - Fixed formatting - Added tracking Support taps * [Release] Merge v2.8.2 into Develop (#158) * [Merge to Master] Develop with tech debt improvements (#123) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade Co-authored-by: Mohamed Barry <[email protected]> * Release/v2.8.0 (#131) * fix crash: window required * compute QR code only once * run code on main thread * update cocoapods firebase * update addresses + event * version bump * remove unused fonts * Updated key for RemoteRunnable in xcscheme * Added Issue templates (#122) - Bug Report - Feature Request - Also have watch xcscheme added per upgrade * [Bugfix] Cleared Simplex (#126) * Disabled Simplex - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker * Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message * ## Release Notes: v2.8.0 (version bump) This release is the first release in months that needed an update based on the changes in the enviroment. In general, the Litewallet code base is bloated with 1000's of lines of unused code and this makes debugging and adding new features very difficult. In addition, the requirements of iOS 14 and the plan to move from UIKit to a SwiftUI+Combine architecture means subsequent PRs will reflect a more streamlined codebase. ## Tech Debt - Also have watch xcscheme added per upgrade - Added Issue templates (#122) - Bug Report - Feature Request - Updated key for RemoteRunnable in xcscheme - remove unused fonts - run code on main thread - update cocoapods firebase - update addresses + event ## Improvements * compute QR code only once - Soft launch for Import QR Code ## Bugfixes * fix crash: window required ## Temporary Workarounds The proxy server the supports buying LTC is being refactored and so no mobile clients can use the Simplex service * Disabled Simplex / Added temp message - Was causing crashes when return messages were happening. - Will update in the next cycle with an updated UI - Added a Analytics: DID TAP BUY TAB marker - Added Coming Soon label to the tableview background view for a temporary sign - Added all translation for the coming soon message ## Authors Kerry Washington <[email protected]> Mohamed Barry <[email protected]> * Removed schemes (#125) Goal: Reduce the codebase in prep for a major refactor. This removed the debug scheme and watch scheme. * [Tech Debt] Remove Apple Watch code (#124) * Remove Apple Watch code - The Apple Code is very old and has never been updated. - There is a longer plan to remove superflous code. - If others ask to re-add it we will look again with the later versions * Removed NotificationServiceExtension - This is cruft that …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.