Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extractLocStrings: error: bad entry in file /xxx/xxx: Argument is not a literal string. #135

Open
yikuo123 opened this issue Jul 5, 2019 · 12 comments

Comments

@yikuo123
Copy link

yikuo123 commented Jul 5, 2019

if the tableName or key is a variable, this problem would occur. Could anyone tell me how can i ignore this error message?

@yikuo123
Copy link
Author

yikuo123 commented Jul 5, 2019

BTW, BartyCrouch 3 is OK

@Jeehut
Copy link
Member

Jeehut commented Jul 8, 2019

There's no way we could support variables as keys or table names in a reasonable amount of time since this requires your app to be built and run and only during runtime would the actual values be really clear – and even then, they could change depending on your variable type. So basically, in order to use BartyCrouch, you need to use String literals. There's no way we could fix this, sorry.

@Jeehut Jeehut added the wontfix label Jul 8, 2019
@Jeehut Jeehut closed this as completed Jul 8, 2019
@Jeehut
Copy link
Member

Jeehut commented Jul 8, 2019

Ah, I just saw that what you want to do is to simply ignore those entries, not infer them. Apple, over time, adds more and more error messages to their tools, in this case extractLocStrings – which is probably why BartyCrouch 3 was working fine (using the deprecated genstrings tool). I'm not sure if extractLocStrings has an option to ignore errors, if it has, we could use that.

We could also redirect those error messages to /dev/null which would fix the error. But then, you lose all the useful error messages, too. A fix could be to specifically ignore only this error. In any case, it could be fixed. But that's not implemented yet. Would be glad over a PR fixing this.

Having that said, if this only happens in a specific file in your project, the simplest workaround for you would be to make sure that file isn't processed by BartyCrouch by specifying a codePath where the file isn't included. Unfortunately, we don't have an exclude option yet, that would also be open to a PR.

@yikuo123
Copy link
Author

yikuo123 commented Jul 8, 2019

@Dschee Can we just ignore this error message and then do nothing ? I wish BartyCrouch just didn't emit this error message.

@yikuo123
Copy link
Author

yikuo123 commented Jul 8, 2019

@Dschee I get it, thank you for your answer

@andtie
Copy link

andtie commented Jul 10, 2019

@yikuo123 You can trick extractLocStrings into accepting variables by wrapping it in a literal string.

E.g.:
NSLocalizedString("\(localizationID)", comment: "\(comment) #bc-ignore!")

@thesunita
Copy link

thesunita commented Jul 30, 2019

This is what I am getting in my project.
Screenshot 2019-07-30 at 5 22 21 PM

Please Note DropDown and GoogleMapPlaces are thirdParty libraries used in project

@yikuo123
Copy link
Author

@thesunita I think you may exclude the Pods directory

@thesunita
Copy link

I came across this #63 before posting screenshot here.

I was assuming as PR has been merged , so /Pods should be there and should work. Do I need to do something else? May be a little help to get right path would be much appreciated.

Note: I have installed BartyCrouch on Mac OS using HomeBrew.

@Jeehut
Copy link
Member

Jeehut commented Aug 5, 2019

@thesunita Can you please post your .bartycrouch.toml file contents? This is most likely a configuration issue. BartyCrouch should actually ignore the Pods directory automatically, but depending on your configuration we might have to alter the logic since it seems, our logic isn't working in your setup ...

@ASamirbadran
Copy link

same issue here

@vince4
Copy link

vince4 commented Feb 3, 2021

I have the same issue using custom function :

static inline NSString *expLocalizeString(NSString *string, NSString *comment) {
    return [EXPCustomConstants localizedStringForKey:string table:@"Label" comment:comment];
}

Produce :

Starting Task 'Update Code' ...
2021-02-03 10:28:19.540: ✅  ../../:  Successfully updated strings file(s) of Code files.
Task 'Update Code' took 0.787 seconds.
extractLocStrings: error: bad entry in file /Users/vincent/Documents/App/exp-ios-core/Constants/EXPConstant.m (line = 326): Argument is not a literal string.
Command PhaseScriptExecution emitted errors but did not return a nonzero exit code to indicate failure

And the build fail.

The only workaround I found is to redirect the error to /dev/null :
bartycrouch update >/dev/null 2>&1

acosmicflamingo added a commit to acosmicflamingo/BartyCrouch that referenced this issue Mar 6, 2021
Replacing NSLocalizedString with CFLocalizedString results in having a
thrown error, even though it still successfully builds. Better to just
ignore the exception entirely. Based on the GitHub discussion in the
following: FlineDev#135
acosmicflamingo added a commit to acosmicflamingo/BartyCrouch that referenced this issue Mar 6, 2021
Replacing NSLocalizedString with CFLocalizedString results in having a
thrown error, even though it still successfully builds. Better to just
ignore the exception entirely. Based on the GitHub discussion in the
following: FlineDev#135
acosmicflamingo added a commit to acosmicflamingo/BartyCrouch that referenced this issue Mar 6, 2021
Also ignoring thrown exception when running extractedString in Xcode.
Replacing NSLocalizedString with CFLocalizedString results in having a
thrown error, even though it still successfully builds. Better to just
ignore the exception entirely. Based on the GitHub discussion in the
following: FlineDev#135
kcw-grunt added a commit to litecoin-foundation/litewallet-ios that referenced this issue Jan 17, 2023
- BC and extractLocStrings did not get along
Barty Crouch have an open issue as extractLocStrings is deprecated by Apple so the script is barfing.
The notes on the issue are here: FlineDev/BartyCrouch#135 (comment)

The other issue was the NSNotificationCenter was not happy and the work around was:
- deinit and remove observers for the new post
- remove the assertFailure (which I added) and replaced it with an LWAnalytics error event
- added a Error NSlog message
- also moved all the NSN to its own file NSNExtension
kcw-grunt added a commit to litecoin-foundation/litewallet-ios that referenced this issue Jan 18, 2023
* Improved language selection

* Fixed transaction completion localization, removed force unwrapings, fixing typos

* autoformat

- BartyCrouch has a bug where the NSLocalizaedString makes extractLocStrings fail.
The workaround is detailed here:
https://github.com/FlineDev/BartyCrouch#exclude-specific-views--nslocalizedstrings-from-localization

* resolved flaky compile issue

- BC and extractLocStrings did not get along
Barty Crouch have an open issue as extractLocStrings is deprecated by Apple so the script is barfing.
The notes on the issue are here: FlineDev/BartyCrouch#135 (comment)

The other issue was the NSNotificationCenter was not happy and the work around was:
- deinit and remove observers for the new post
- remove the assertFailure (which I added) and replaced it with an LWAnalytics error event
- added a Error NSlog message
- also moved all the NSN to its own file NSNExtension

* bump version

- polished language view

Co-authored-by: kcw-grunt <[email protected]>
kcw-grunt added a commit to litecoin-foundation/litewallet-ios that referenced this issue Jan 26, 2023
* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🚧[Techdebt] Firebase polish 121 (#139)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* build bump

-clean up strings file
- Udpated to iOS 14.0 as a target
https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/

* Removed cruft

* Updated the Firebase constants

- changed it to lowercase

* updated links

* fixed constants

-build bump

* reemvoed conflict tags

* Mark unused code (#147)

* Added and modified a ruby script that shows a warining if a class, function or variable is not used

* Fixed static function partnersDataArray

* Updated build number

* changed the urtl

- change the deployment target

* Retired old https server code (#154)

* #148 Fixed a crash that appeared when the users wallet was aout of sync and a prompt neaded to appear

* Removed dispatchqueue.async that was used for testing

* 🚀[Release v3.10.1] Merge into Develop (#162)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🚧[Techdebt] Firebase polish 121 (#139)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* build bump

-clean up strings file
- Udpated to iOS 14.0 as a target
https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/

* Removed cruft

* Updated the Firebase constants

- changed it to lowercase

* updated links

* fixed constants

-build bump

* Mark unused code (#147)

* Added and modified a ruby script that shows a warining if a class, function or variable is not used

* Fixed static function partnersDataArray

* Updated build number

* build bump

* clean up duplicate scripts

* readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]";

-bumped the version and build to test Bitrise

* fixed today extension version and build number

* fixed coding norm (space after colon)

- fixed Turkish - Italian mixup
- version bump

* Add SwiftFormat to the codebase (#159)

* Added SwiftFormat to the run scripts

* Removed --elseOnSameLine from rules as it is on by default

* Added --disable enumNamespaces rule

* Using SwiftFormat to auto-format current code

* Removed --allman rule

* 🚀[Release v3.10.1] Merge into Develop (#162)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🚧[Techdebt] Firebase polish 121 (#139)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* build bump

-clean up strings file
- Udpated to iOS 14.0 as a target
https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/

* Removed cruft

* Updated the Firebase constants

- changed it to lowercase

* updated links

* fixed constants

-build bump

* Mark unused code (#147)

* Added and modified a ruby script that shows a warining if a class, function or variable is not used

* Fixed static function partnersDataArray

* Updated build number

* build bump

* clean up duplicate scripts

* readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]";

-bumped the version and build to test Bitrise

* fixed today extension version and build number

* fixed coding norm (space after colon)

- fixed Turkish - Italian mixup
- version bump

* Added SwiftFormat to the run scripts

* Removed --elseOnSameLine from rules as it is on by default

* Added --disable enumNamespaces rule

* Using SwiftFormat to auto-format current code

* Removed --allman rule

* PartnerData auto-format

* Added marking of unused code back to runscripts

* Delete PubtoPrivate.yml

* Delete sync-mirror.yml

Co-authored-by: Kerry Washington <[email protected]>

* 🤬[Techdebt] #167 add custom user agent++ (#168)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🚧[Techdebt] Firebase polish 121 (#139)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* build bump

-clean up strings file
- Udpated to iOS 14.0 as a target
https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/

* Removed cruft

* Updated the Firebase constants

- changed it to lowercase

* updated links

* fixed constants

-build bump

* Mark unused code (#147)

* Added and modified a ruby script that shows a warining if a class, function or variable is not used

* Fixed static function partnersDataArray

* Updated build number

* changed the urtl

- change the deployment target

* removed staging server url

normalizing to the prod server only

* aded small test

- build bump

* Retired old https server code (#154)

* Updated

* 🚀[Release v3.10.1] Merge into Develop (#162)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🚧[Techdebt] Firebase polish 121 (#139)

* 🚀[Release v3.10.0] Merge into Main  (#136)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* Create sync-mirror.yml

* Changed the clone sig

* Update sync-mirror.yml

- added sync branches and tags

* Update sync-mirror.yml

refactor

* Update sync-mirror.yml

fixed uname

* Update sync-mirror.yml

* Update sync-mirror.yml

* Create PubtoPrivate.yml

* Update sync-mirror.yml

* 🚀[Release v3.10.0] Merge into Develop (#135)

* 🦺[Techdebt] fix firebase (#115)

* Update firebase config
 auto clean up strings

- version bump
- Commented out debug FB file

* Checked the version is sending FB data

- bump build number

* 🥳[Techdebt] relayout address view controller (#120)

* Successfully placed in UIHosting Address

Updated the strings file

* Added event

* added delay

- used for animating U Domain

* Added function of subviews in SendViewController

Layout is updated

* Adding the function to the send

Cleaned up and wired up Cells
- UD View/Model
- Send Address View/Model
Reset the amount Label in SendViewController

* Refactored SendButton

- Using UIHostingViewController

* Successfully send LTC

-WIP: fix white space

* Refactored the layout of the send  button

* buiid bump (#125)

* [Techdebt] ci cd refactor (#132)

* Removed flaky tests

* build bump

* build bump

* removed unused file

- build bump

* build bump

* fixed scan QR (#130)

* fixed scan QR

* update gitignore

* Feature/add bitrefill new (#134)

* Added llocalView

- added bitrefill
- basic function is available
- build bump

* bump

* added basic web widget

* updated logo

* build bump

* changed the Bitrefill link

- build bump

* pre-bump version

- to get a binary to TestFlight

* build bump

* build bump again

* Clean up background

* build bump

* build bump

-clean up strings file
- Udpated to iOS 14.0 as a target
https://www.statista.com/statistics/1118925/mobile-apple-ios-version-share-worldwide/

* Removed cruft

* Updated the Firebase constants

- changed it to lowercase

* updated links

* fixed constants

-build bump

* Mark unused code (#147)

* Added and modified a ruby script that shows a warining if a class, function or variable is not used

* Fixed static function partnersDataArray

* Updated build number

* build bump

* clean up duplicate scripts

* readded "Send.UnstoppableDomains.udSystemError" = "System lookup problem. [Error: %2$d]";

-bumped the version and build to test Bitrise

* fixed today extension version and build number

* fixed coding norm (space after colon)

- fixed Turkish - Italian mixup
- version bump

* added custom var

* build bump

* Add codesigndoc ignore

* Added Swift Packages to the project

- Closes : #156

* Removed pods

* Added Litewallet PartnerAPI to project

* SUCCESS!

- Added PartnerAPI as a Submodule

* Rebase from SwiftFormat

* Update .gitignore

* Removed submodule

* resetting add the submodule

* updated config

* Removed PartnerAPI #170

Removed references to the LitewalletPartnerAPI lib
- Compiled the app
- Added LitecoinCard View for CardView
- Added CardWebViewController
- Deleted unused views and viewModels

* change build number

* Rmeoved all LitecoinCard Tests

* build bump

* Failed Test for Bitrise CI

* Unbroken tests

* small change build bump

* another build bump

* build again

* build bump

* yet again bump

* small change

* matching build number with bitrise run

* nonsense change

* Fixed the UDSystem Error issues

- removed commented out PartnerAPI Code

Co-authored-by: Iferencak <[email protected]>

* Delete sync-mirror.yml (#176)

* Delete push-to-release-email.yml (#175)

* Delete github-actions.yml (#174)

deleting unused workflow

* Update README.md (#173)

Added a reminder to cleanup Old workflow runs

* improved language switching, fixed transparent navigation bar bug (#179)

* Improved language selection

* Fixed transaction completion localization, removed force unwrapings, fixing typos

* autoformat

- BartyCrouch has a bug where the NSLocalizaedString makes extractLocStrings fail.
The workaround is detailed here:
https://github.com/FlineDev/BartyCrouch#exclude-specific-views--nslocalizedstrings-from-localization

* resolved flaky compile issue

- BC and extractLocStrings did not get along
Barty Crouch have an open issue as extractLocStrings is deprecated by Apple so the script is barfing.
The notes on the issue are here: FlineDev/BartyCrouch#135 (comment)

The other issue was the NSNotificationCenter was not happy and the work around was:
- deinit and remove observers for the new post
- remove the assertFailure (which I added) and replaced it with an LWAnalytics error event
- added a Error NSlog message
- also moved all the NSN to its own file NSNExtension

* bump version

- polished language view

Co-authored-by: kcw-grunt <[email protected]>

* version bump

- build bump

* build bump to trigger bitrise

* bump for matching bitrise

* Fixed a crash when force trying to get a creation date of unexisting file (#188)

Co-authored-by: Iferencak <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants