improved language switching, fixed transparent navigation bar bug #179
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd"> | ||
| <plist version="1.0"> | ||
| <dict> | ||
| <key>IDEDidComputeMac32BitWarning</key> | ||
| <true/> | ||
| </dict> | ||
| </plist> | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import Foundation | ||
|
|
||
| var _bundle: UInt8 = 0 | ||
|
|
||
|
There was a problem hiding this comment. I love this solution. If I understand correctly, BundleEx does the heavy lifting of converting all the strings to the chosen language in a DQ? Its quite smooth Only thing is I generally prefer Can we do : Maybe it will never be called but it will help us sleep a little better. There was a problem hiding this comment. Sure thing, looks like i missed it after I finished prototyping. On it. |
||
| class BundleEx: Bundle { | ||
| override func localizedString(forKey key: String, value: String?, table tableName: String?) -> String { | ||
| let bundle: Bundle? = objc_getAssociatedObject(self, &_bundle) as? Bundle | ||
|
|
||
| if let temp = bundle { | ||
| return temp.localizedString(forKey: key, value: value, table: tableName) | ||
| } else { | ||
| return super.localizedString(forKey: key, value: value, table: tableName) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| public extension Bundle { | ||
| class func setLanguage(_ language: String?) { | ||
| let oneToken = "com.litecoin.loafwallet" | ||
|
|
||
| DispatchQueue.once(token: oneToken) { | ||
| object_setClass(Bundle.main, BundleEx.self as AnyClass) | ||
| } | ||
|
|
||
| if let temp = language { | ||
| objc_setAssociatedObject(Bundle.main, &_bundle, Bundle(path: Bundle.main.path(forResource: temp, ofType: "lproj")!), .OBJC_ASSOCIATION_RETAIN_NONATOMIC) | ||
| } else { | ||
| objc_setAssociatedObject(Bundle.main, &_bundle, nil, .OBJC_ASSOCIATION_RETAIN_NONATOMIC) | ||
| } | ||
| } | ||
| } | ||
|
|
||
| extension DispatchQueue { | ||
| private static var _onceTracker = [String]() | ||
|
|
||
| class func once(token: String, block: () -> Void) { | ||
| objc_sync_enter(self); defer { objc_sync_exit(self) } | ||
|
|
||
| if _onceTracker.contains(token) { | ||
| return | ||
| } | ||
|
|
||
| _onceTracker.append(token) | ||
| block() | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thought I .gitignored xcshareddata? @Iferencak . Is this a new setting? Should I migrate with it? Whats the benefit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly I'm not sure how this got tracked.. I didn't touch .gitignore 🤷