Add new account version that supports MuSig2 v1.0.0-rc2 protocol (coming with lnd 0.16.0-beta) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@positiveblue Christmas came early this year, we now have feature flag bases batch versions 😎 |
ffranr
approved these changes
Feb 7, 2023
account/manager_test.go
Outdated
| accountInputFeesTaproot, | ||
|
|
||
| // We'll use the lowest fee rate possible, which should | ||
| // yield a transaction fee of 304 satoshis when taking |
There was a problem hiding this comment.
nit: I think that specifics like "304" will become stale as they are hard to keep up-to-date. A assertion in code would be an alternative. I would suggest removal from the comment.
There was a problem hiding this comment.
Yeah, good call. I replaced the magic number with a constant and removed the comments.
guggero
force-pushed
the
musig2-1-0
branch
2 times, most recently
from
5b8469d to
0db3a9f
Compare
This commit bumps the compile time dependency of lnd and lndclient to the 0.16.x branch. This makes the code forward compatible but does not yet change anything with respect to the minimum required version the user needs to run.
Since any version prior to v0.15.4-beta will not sync to the mainnet chain, we can safely bump the minimum required version to that since no older version will be running (properly) anywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on lightningnetwork/lnd#7171.Depends on lightninglabs/lndclient#139.This PR add support for the updated MuSig2
v1.0.0-rc2protocol to Pool accounts.The order for getting this in is:
lnd v0.16.0-beta(.rcX)MuSig2CreateSessioncall lndclient#139Pull Request Checklist
used.