-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multi: bump lnd+lndclient compile time dependency #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🙏
Shall we also bump the minimum lnd version to 0.15.99? |
I don't think we added anything that requires runtime compatibility. So |
Shall we merge this given rc1 is out? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚀
Integration test seems to be flaky, it did complete on my machine. Kicked it again, let's see. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second commit says v1.19.2
but we bump golang to v1.19.4
This PR adds compile time compatibility with lnd 0.16.
Pull Request Checklist
MinLndVersion
if your PR uses new RPC methods or fields oflnd
.