Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

multi: bump lnd+lndclient compile time dependency #157

Merged
merged 2 commits into from
Feb 27, 2023
Merged

multi: bump lnd+lndclient compile time dependency #157

merged 2 commits into from
Feb 27, 2023

Conversation

guggero
Copy link
Member

@guggero guggero commented Feb 8, 2023

This PR adds compile time compatibility with lnd 0.16.

Pull Request Checklist

  • Update MinLndVersion if your PR uses new RPC methods or fields of lnd.

Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙏

@bhandras
Copy link
Member

bhandras commented Feb 8, 2023

Shall we also bump the minimum lnd version to 0.15.99?

@guggero
Copy link
Member Author

guggero commented Feb 8, 2023

Shall we also bump the minimum lnd version to 0.15.99?

I don't think we added anything that requires runtime compatibility. So lnd 0.15.4-beta should be fine.

@bhandras
Copy link
Member

Shall we merge this given rc1 is out?

@guggero guggero marked this pull request as ready for review February 24, 2023 18:21
@guggero guggero requested a review from bhandras February 24, 2023 18:21
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀

@guggero
Copy link
Member Author

guggero commented Feb 24, 2023

Integration test seems to be flaky, it did complete on my machine. Kicked it again, let's see.

@guggero guggero requested a review from positiveblue February 24, 2023 18:39
Copy link
Contributor

@positiveblue positiveblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The second commit says v1.19.2 but we bump golang to v1.19.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants