Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumped reccommended LND version #424

Closed
wants to merge 1 commit into from
Closed

Conversation

rstmsn
Copy link

@rstmsn rstmsn commented Dec 11, 2022

Bumped reccommended LND version to 0.15.4-beta

Bumped reccommended LND version to 0.15.4-beta
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for flagging this outdated sentence. The minimum required version was bumped to v0.15.1-beta a while back, so the first part of the sentence should also be updated. Maybe we can even link to the section in the code so it's easier to check?

@rstmsn
Copy link
Author

rstmsn commented Dec 19, 2022

Thanks for flagging this outdated sentence. The minimum required version was bumped to v0.15.1-beta a while back, so the first part of the sentence should also be updated. Maybe we can even link to the section in the code so it's easier to check?

Would you agree that it would make more sense to also bump the minimum required version in the code to 0.15.4-beta, as this is the update that patches the large taproot transaction bug ?
Presumably loop will fail to run if it's operating on top of an lnd that is not patched for this issue?

Grateful for thoughts in case I have overlooked something.

@guggero
Copy link
Member

guggero commented Jan 3, 2023

Would you agree that it would make more sense to also bump the minimum required version in the code to 0.15.4-beta, as this is the update that patches the large taproot transaction bug ?

Yes, I think that makes sense.

@lightninglabs-deploy
Copy link
Collaborator

@rstmsn, remember to re-request review from reviewers when ready

@guggero
Copy link
Member

guggero commented Jan 31, 2023

Replaced by #435.

@guggero guggero closed this Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants