Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS release needs Flipper disabled (fixed in 0.69.2/0.70) #757

Closed
2 tasks done
leotm opened this issue Jul 7, 2022 · 0 comments · Fixed by #791
Closed
2 tasks done

iOS release needs Flipper disabled (fixed in 0.69.2/0.70) #757

leotm opened this issue Jul 7, 2022 · 0 comments · Fixed by #791
Labels
cocoapods CocoaPods changes for building iOS and tvOS flipper Flipper changes ios Native iOS changes (Swift, C++, CocoaPods) p: Facebook Partner: Meta release mode Production build variant

Comments

@leotm
Copy link
Owner

leotm commented Jul 7, 2022 •
edited
Loading

iOS (fixed in 0.69.2)
@leotm leotm added ios Native iOS changes (Swift, C++, CocoaPods) flipper Flipper changes cocoapods CocoaPods changes for building iOS and tvOS release mode Production build variant labels Jul 7, 2022
@leotm leotm mentioned this issue Jul 7, 2022
Merged
21 tasks
@leotm leotm added the p: Facebook Partner: Meta label Jul 8, 2022
@leotm leotm changed the title iOS release needs Flipper disabled (fixed in 0.69.2) iOS release needs Flipper disabled (fixed in 0.69.2, 0.70rc?) Jul 18, 2022
@leotm leotm changed the title iOS release needs Flipper disabled (fixed in 0.69.2, 0.70rc?) iOS release needs Flipper disabled (fixed in 0.69.2/0.70) Jul 18, 2022
leotm added a commit that referenced this issue Jul 20, 2022
@leotm
Add iOS prod flag from RN 0.69.1->0.69.2
71e6cab 
- missed in 0.69.1->0.70.0-rc.0 upg
- since 0.69.2 released 4 days later
- add 0.69.1->0.69.2 upg
- changes still not in main template
  - branches /main or 0.70-stable

Did
https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.70.0-rc.0

Now need to apply out 4 days later
https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.69.2

Now need to PR to main template

Fix: #757
@leotm leotm mentioned this issue Jul 20, 2022
Merged
@leotm leotm mentioned this issue Jul 20, 2022
Closed
facebook-github-bot pushed a commit to facebook/react-native that referenced this issue Jul 22, 2022
@leotm @facebook-github-bot
Update Podfile for PRODUCTION=1 pod install (#34234)
77752fc 
Summary:
### Mentioned
- pr[main]: #33882
- discussion: reactwg/react-native-releases#21 (reply in thread)
- pr[0.69-stable]: #34098

Close: #33764

Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757
Fixed similarly: leotm/react-native-template-new-architecture#791

## Changelog

[iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install`

[CATEGORY] [TYPE] - Message

Pull Request resolved: #34234

Test Plan: Everything builds and runs as expected

Reviewed By: cortinico

Differential Revision: D38029117

Pulled By: cipolleschi

fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
kelset pushed a commit to facebook/react-native that referenced this issue Jul 27, 2022
@leotm @kelset
Update Podfile for PRODUCTION=1 pod install (#34234)
bf34be1 
Summary:
### Mentioned
- pr[main]: #33882
- discussion: reactwg/react-native-releases#21 (reply in thread)
- pr[0.69-stable]: #34098

Close: #33764

Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757
Fixed similarly: leotm/react-native-template-new-architecture#791

## Changelog

[iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install`

[CATEGORY] [TYPE] - Message

Pull Request resolved: #34234

Test Plan: Everything builds and runs as expected

Reviewed By: cortinico

Differential Revision: D38029117

Pulled By: cipolleschi

fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cocoapods CocoaPods changes for building iOS and tvOS flipper Flipper changes ios Native iOS changes (Swift, C++, CocoaPods) p: Facebook Partner: Meta release mode Production build variant
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add iOS prod flag from RN 0.69.1->0.69.2 leotm/react-native-template-new-architecture
1 participant
@leotm