-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS CI Release on macos-12
#690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leotm
added a commit
that referenced
this pull request
Jun 23, 2022
Debug fine locally For Release note - reactwg/react-native-releases#23 (comment) - #690
7 tasks
leotm
added a commit
that referenced
this pull request
Jul 25, 2022
Follow-up: - facebook/react-native#34274 (comment) Also update parts in-line with current main - https://github.com/facebook/react-native/tree/main/template
leotm
added a commit
to leotm/RN070RC1
that referenced
this pull request
Aug 2, 2022
Additional bundle step was added just in case in: leotm/react-native-template-new-architecture#690 But strange unable to output here, but fine in PR above
macos-12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci
GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing
ios
Native iOS changes (Swift, C++, CocoaPods)
macOS
p: Facebook
Partner: Meta
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
iOS Release workflow
use_flipper
logic insideuse_react_native
and simplify the Flipper dependencies logic facebook/react-native#33882@nightly
(branches: main, 0.69.0-stable) +PRODUCTION=1 RCT_NEW_ARCH_ENABLED=1 pod install
0.0.0-20220620-2049-e5c5dcd9e
pod install
☠️ (folly/hermes-engine)0.0.0-20220621-2056-68f3a42fc
use_flipper
logic insideuse_react_native
and simplify the Flipper dependencies logic facebook/react-native#33882@nightly
otherwise prev snapshotsindex.js
entryFile copy for nowmacos-12
)patch scripts/react-native-xcode.shError
react_native_pods.rb
for iOS Release build facebook/react-native#34234 (picked for RN0.70.0-rc.1
)Error 2 (current)
tl;dr iOS Release
TS-only entryFile: macOS 13b, Xcode 14b w Node v18
JS-only entryFile: macOS 12 w Xcode 13 w Node v16
Close 757Close 794Fix: #822
Unblock: #615