Add iOS prod flag from RN 0.69.1->0.69.2 #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- missed in 0.69.1->0.70.0-rc.0 upg - since 0.69.2 released 4 days later - add 0.69.1->0.69.2 upg - changes still not in main template - branches /main or 0.70-stable Did https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.70.0-rc.0 Now need to apply out 4 days later https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.69.2 Now need to PR to main template Fix: #757
leotm
added
ios
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 22, 2022
Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
This was referenced Jul 25, 2022
kelset
pushed a commit
to facebook/react-native
that referenced
this pull request
Jul 27, 2022
Summary: ### Mentioned - pr[main]: #33882 - discussion: reactwg/react-native-releases#21 (reply in thread) - pr[0.69-stable]: #34098 Close: #33764 Saw the issue ago couple wks too: leotm/react-native-template-new-architecture#757 Fixed similarly: leotm/react-native-template-new-architecture#791 ## Changelog [iOS] [Changed] - Update Podfile to allow `PRODUCTION=1 pod install` [CATEGORY] [TYPE] - Message Pull Request resolved: #34234 Test Plan: Everything builds and runs as expected Reviewed By: cortinico Differential Revision: D38029117 Pulled By: cipolleschi fbshipit-source-id: bdb58200a999cb66f1043a2feb670f9037c8e463
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did
https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.70.0-rc.0
Now need to apply out 4 days later
https://react-native-community.github.io/upgrade-helper/?from=0.69.1&to=0.69.2
Now need to PR to main template
Fix: #757
Unblock: #690