Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessibility review #41

Closed
leekelleher opened this issue Sep 4, 2020 · 6 comments
Closed

Accessibility review #41

leekelleher opened this issue Sep 4, 2020 · 6 comments
Assignees
@leekelleher
Labels
help wanted Extra attention is needed type/question Further information is requested

Comments

@leekelleher
Copy link
Owner

leekelleher commented Sep 4, 2020 •
edited
Loading

In light of the great success of the Umbraco Accessibility Team, I'd like for Contentment to pull it's own weight and ensure that the same principles have been applied.

I've tried to make efforts to ensure accessibility, e.g. use of <button>, ARIA, labelling, etc. But I'm never sure it is truly accessible. It'd be great to have help with accessibility concerns. I'd love to learn something too.

Background reading

Feedback, expectations and Hackotoberfest

Whilst code patches are hugely appreciated, my expectation for collaboration on any accessibility review is more about raising issues for feedback. My hope is to highlight any accessibility issues that even seasoned developers can mistake.

Pull Requests (so far) ...
@leekelleher leekelleher added help wanted Extra attention is needed type/question Further information is requested labels Sep 4, 2020
@leekelleher leekelleher self-assigned this Sep 4, 2020
@zersiax

This comment has been minimized.

Sign in to view
@leekelleher

This comment has been minimized.

Sign in to view
@greystate

This comment has been minimized.

Sign in to view
@leekelleher

This comment has been minimized.

Sign in to view
@greystate

This comment has been minimized.

Sign in to view
leekelleher added a commit that referenced this issue Oct 25, 2020
@leekelleher
ItemPicker overlay - change <a> to <button>
ba20147 
I small change, for part of the Accessibility review #41.
leekelleher added a commit that referenced this issue Oct 25, 2020
@leekelleher
ItemPicker - overlay closed, ensure focus
4527f87 
A small change, for part of the Accessibility review #41.

Uses Umbraco's `focusService` to remember the current focus
state before the ItemPicker's overlay is opened. Once it is closed,
the focus state is restored.
@leekelleher leekelleher mentioned this issue Oct 25, 2020
Merged
4 tasks
@leekelleher
Copy link
Owner Author

Closing off this specific ticket, as it should be an ongoing concern.
I'll endeavour to review and improve the accessibility of the editors. 👍

leekelleher added a commit that referenced this issue Apr 16, 2021
@leekelleher
ItemPicker - overlay closed, ensure focus
805401a 
A small change, for part of the Accessibility review #41.

Uses Umbraco's `focusService` to remember the current focus
state before the ItemPicker's overlay is opened. Once it is closed,
the focus state is restored.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leekelleher leekelleher

Labels
help wanted Extra attention is needed type/question Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@greystate @leekelleher @zersiax