ItemPicker overlay - change <a> to <button>

I small change, for part of the Accessibility review #41.
leekelleher · Oct 25, 2020 · ba20147 · ba20147
1 parent 6beb75f
commit ba20147
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/Umbraco.Community.Contentment/DataEditors/ItemPicker/item-picker.overlay.html b/src/Umbraco.Community.Contentment/DataEditors/ItemPicker/item-picker.overlay.html
@@ -45,14 +45,14 @@
 
                     <ul class="umb-actions umb-actions-child" ng-if="vm.listType === 'list'">
                         <li class="umb-action" ng-class="{ '-disabled': item.disabled }" ng-repeat="item in vm.items | orderBy:vm.orderBy | filter:vm.searchTerm">
-                            <a class="umb-action-link" ng-click="vm.select(item)">
+                            <button type="button" class="umb-action-link umb-outline btn-reset" ng-click="vm.select(item)">
                                 <umb-checkmark ng-if="vm.enableMultiple" checked="item.selected" size="m"></umb-checkmark>
-                                <i class="large icon" ng-class="item.icon || vm.defaultIcon"></i>
+                                <i class="large icon" ng-class="item.icon || vm.defaultIcon" aria-hidden="true"></i>
                                 <span class="menu-label">
                                     <span ng-bind="item.name"></span>
                                     <small ng-bind="item.description"></small>
                                 </span>
-                            </a>
+                            </button>
                         </li>
                     </ul>