ItemPicker - when overlay is closed, focus state is restored #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leekelleher
changed the title
A small change, for part of the Accessibility review #41. Uses Umbraco's `focusService` to remember the current focus state before the ItemPicker's overlay is opened. Once it is closed, the focus state is restored.
leekelleher
force-pushed
the
wip/itempicker-overlay-close-focus
branch
from
4527f87 to
805401a
Compare
|
Merging in, while I'm not totally happy with this, (there is room for big improvements here), I do feel that a small incremental improvement is better than none. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@BatJan - would you be able to advice if this approach aligns with how this is being done in Umbraco? and/or if there is a better approach? (Thank you in advance.)
Description
Uses Umbraco's
focusServiceto remember the current focus state before the ItemPicker's overlay is opened.Once the overlay is closed, the focus state is restored.
Related Issues?
Types of changes
Checklist