Ignore duplicate room resources when scheduling classes #3695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkbrum
approved these changes
Nov 29, 2023
willgearty
added a commit
that referenced
this pull request
Jan 5, 2024
* Docs for #3670, #3672, #3671, and #3676 * Docs for #3677, #3673, #3681, and #3683 * Docs for #3682, #3678, #3684, and 74b7e0f * Docs for 74b7e0f, #3685, #3687, and #3686 * Docs for #3688, #3694, #3695, #3692, and #3691 * Docs for #3642, #3696, #3697, and #3700 * change date and add customized buttons for bigpicture * add theme help text --------- Co-authored-by: Katherine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While it is not currently possible to create duplicate classrooms (see #303 (comment)), this makes it so any stray duplicate room resources (either those created before such duplicates were made impossible or those created manually in the admin panel) do not cause issues when scheduling classes with the ajax scheduler. We now ignore any of these duplicates, and the order_by() call should make it so we always ignore the same duplicate resource(s).
Fixes #1188.