Fix form submission handling #3672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might also fix #3664, but I haven't checked. |
|
This now fixes #3664 (which was a different issue). |
kkbrum
approved these changes
Aug 25, 2023
willgearty
added a commit
that referenced
this pull request
Jan 5, 2024
* Docs for #3670, #3672, #3671, and #3676 * Docs for #3677, #3673, #3681, and #3683 * Docs for #3682, #3678, #3684, and 74b7e0f * Docs for 74b7e0f, #3685, #3687, and #3686 * Docs for #3688, #3694, #3695, #3692, and #3691 * Docs for #3642, #3696, #3697, and #3700 * change date and add customized buttons for bigpicture * add theme help text --------- Co-authored-by: Katherine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the way that we handle form submissions (with respect to the previous fix to prevent double button presses). I have only tested this behavior on the class registration form, but it seems to work well there (including with the popup when the grade range is too wide). During review it would probably be good to check a few other forms to make sure they all still work, too.
Fixes #3668. Fixes #3664.