Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add and fix moderator scheduling checks #3678

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Add and fix moderator scheduling checks #3678

merged 6 commits into from
Sep 27, 2023

Conversation

willgearty
Copy link
Member

This adds a moderator availability scheduling check to the ajax scheduler and the scheduling checks page. It also fixes the moderator title for all checks in both of these places.

I also adjusted the coloration of the cells for the teacher/moderator availability checks to be based on the proportion of teachers that are unavailable (1/1 unavailable is the same color as 5/5 unavailable, which are both much darker than 1/5 unavailable).

Note, I also fixed the tab spacing in one of the files (hence why the diff looks like I changed a lot).

Fixes #3665.

Copy link
Contributor

@kkbrum kkbrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good so far. There is an edge case of when someone is moderating and teaching at the same time. The checks show that there is a teacher teaching when they aren't available, but the moderator check does not show an issue. I actually think neither of these should show an issue and that it should show the issue under double booked teachers (it doesnt). Perhaps we also want to add a double booked moderator check, or just include them in the double booked teacher check (my preference, i think).

@willgearty
Copy link
Member Author

Thanks for the great comments, @kkbrum! I believe I've addressed all of them. Teacher and moderator availability checks now skip the other availabilities, while the double-booked check now covers both.

@willgearty willgearty merged commit c8f2994 into main Sep 27, 2023
@willgearty willgearty deleted the mod-check branch September 27, 2023 00:38
willgearty added a commit that referenced this pull request Dec 6, 2023
willgearty added a commit that referenced this pull request Jan 5, 2024
* Docs for #3670, #3672, #3671, and #3676

* Docs for #3677, #3673, #3681, and #3683

* Docs for #3682, #3678, #3684, and 74b7e0f

* Docs for 74b7e0f, #3685, #3687, and #3686

* Docs for #3688, #3694, #3695, #3692, and #3691

* Docs for #3642, #3696, #3697, and #3700

* change date and add customized buttons for bigpicture

* add theme help text

---------

Co-authored-by: Katherine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Moderator scheduling checks
2 participants