-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
weird overlay in notebook list when hover one #7506
Comments
do you use any theme or plugin? |
I never changed anything consciously |
It sounds like a display bug. Does it still happen if you reboot your computer? Did you change a graphic driver recently? |
I am experiencing this issue as well after updating to Joplin 2.9.17. |
What's that extra overlay exactly? Is that some text being overlayed or just random pixels? |
It feels like random pixels. Note that it affects not just the text but also the notebook icon |
I noticed this morning that some of the messed up looking text was blinking in sync with the cursor in the Joplin note I was working on. Not sure if that is helpful. |
The same bug. Joplin 2.9.17 (prod, linux) - appimage Operating System: EndeavourOS The same on the XFCE desktop. Actually this bug appeared after new XFCE 4.18 and was the reason I switched to KDE. But KDE shows the same. |
Is there an upstream bug about this somewhere? Maybe on Electron repository or Linux graphic driver? If it helps we can upgrade Electron but it would be good to know to which version |
I know there is a bug on the Mesa driver for intel 11th gen processors with intel Xe graphics card. Here for merge request who fix the bug : https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9903 |
Noticed this today myself. I'm (was) using the AppImage for v2.9.17 OS: Linux Mint 21.1 x86_64 I have no additional plugins installed either. |
I was on older Fedora up until two days ago and with older Joplin. Today I'm on latest Linux Mint with cinnamon, and latest Joplin and I've faced the same issue as others are describing. You can get the proper name when on mouse hover, sometimes even when just scrolling with scrollbar. However, I don't see broken icons, only notebook titles unlike in some other reports. I did fresh install, with no plugins and no userchrome.css, I did both sh and flatpak installations several times, I thought my backup of joplin was broken, so I even gave it download everything from sync. I lost count of reinstalls I've done 🤣 Also, same behaviour is with default instalation, but also after nvidia drivers were installed. Also various resolution / zoom levels tried. After installing plugins and setting userchrome to my liking, the issue is still here, if this info helps anyhow. Edit: I've now on Joplin 2.8.8, and can confirm that I don't have those issues. |
Anyone reported this on the Electron repository? I don't think it's something we can fix this looks like bad interaction between Electron and the graphic driver |
You think? But how to explain it to the Electron team? I have many Electron apps, but only Joplin behaves in this way. More strange is that:
Only the Notebooks names and Tags names overlaying each other. Like fragments from the line X goes to the line X+1 and from X+1 to X+2 and further... What is so special about layer with Notebooks and Tags? |
We're only displaying valid HTML, that works fine on macOS and Windows and there's nothing in our code that can say "please randomly break the text on Linux" which is why I assume it's something to do with the display driver. Perhaps we are hitting some edge case that breaks the Linux driver, and other apps don't do that. If we can tweak that HTML to prevent this I don't mind and would accept a PR, but personally I can't replicate it because I'm not on Linux |
Ok, it's sad. My knowledge isn't enough to report this bug in a right manner to the Electron team :( |
That's great, thanks for sharing the fix @libremaster! We'll add this to the main app when running in Linux |
I did a test with pre-release 2.10.11 in fedora 37 with gnome and the bug is present in the list of tags but not in the list of notebooks |
Please open a new issue with screenshot |
Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users. The problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using `position: relative` to create a new one for affected text elements is an alternative workaround that has no effect on styling. Ref: laurent22#7506 Ref: laurent22#8000
I have just finished creating a workaround for the same issue in Logseq #7233. The conclusion is an Electron (Chromium) Linux Intel GPU rendering problem that really should be reported upstream. Although setting the opacity does workaround the issue it is at the slight expense of a brighter UI for Linux users. After some further digging I found that the fractional opacity setting is creating a stacking context for the icon and text elements resulting in a rendering bug. This can be worked around by forcing a separate stacking context for the text elements. I have submitted a PR but here is the change for using in .list-item .title, .list-item .tag-label{
position: relative;
} |
Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users. The problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using `position: relative` to create a new one for affected text elements is an alternative workaround that has no effect on styling. Ref: laurent22#7506 Ref: laurent22#8000 Signed-off-by: Calum Lind <[email protected]>
Maybe that's where we should focus our efforts? I'm not so keen on adding further workaround and would rather wait from an upstream fix |
I agree and understand reticence about adding more workarounds but in this case I am simplifying and narrowing down the workaround to restore the correct sidebar opacity for Linux users. I looked at creating an upstream bug at Electron but 19 & 20 are unsupported so reporting will likely be rejected. I also expect we will need to create a sample Electron app with the simplest example recreating the issue on 19 or 20, test in latest versions then report it. I made a tiny start on it but have other tasks to get back to... |
Maybe it will fix itself when we upgrade Electron, so I'd wait at least for this |
I finally managed to small-scale replicate and created an upstream bug report. Seems it's been broken since v18 and still not fixed in v24 |
The selector should be |
@zgs225 Have you tried my changes since they will not change the opacity of the sidebar items?
|
Linux users still reporting corrupted text in sidebar. This is a result of applying a new workaround in 03424f7. However it seems that testing with particular folder structure and icons was overlooked. The new issue is still a Chrome Intel GPU bug but because note count also sets opacity this is another factor requiring fixed. Perhaps the note count opacity was also the reason for the tag text corruption. Fixed by removing opacity from note count and using the more correct text styling of colorFaded2 which has 0.5 alpha channel, as used by AllNotes. Related: laurent22#7506 Fixes: laurent22#8297
Environment
Joplin version: Joplin 2.9.17 (prod, linux) Revision: a84a8e7
Platform: Desktop
OS specifics: Linux, Ubuntu 22.04, Gnome
Steps to reproduce
some strange text-overlay is shown in the lower notebooks
Describe what you expected to happen
The other notebook in the list should not change the look
The text was updated successfully, but these errors were encountered: