Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desktop: Improve sidebar workaround for Linux w/Intel GPU #8126

Merged
merged 1 commit into from
May 29, 2023

Conversation

cas--
Copy link
Contributor

@cas-- cas-- commented May 4, 2023

Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users.

The problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using position: relative to create a new one for affected text elements is an alternative workaround that has no effect on styling.

Ref: #7506
Ref: #8000

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@cas--
Copy link
Contributor Author

cas-- commented May 4, 2023

I have read the CLA Document and I hereby sign the CLA

@cas--
Copy link
Contributor Author

cas-- commented May 4, 2023

recheck

github-actions bot added a commit that referenced this pull request May 4, 2023
Previous fixes set an opacity value of 1 which affects the sidebar
styling for Linux users.

The problem of corrupted text in the sidebar seems to be related to
stacking contexts therefore using `position: relative` to create a new
one for affected text elements is an alternative workaround that has no
effect on styling.

Ref: laurent22#7506
Ref: laurent22#8000
Signed-off-by: Calum Lind <[email protected]>
@cas-- cas-- force-pushed the fix/linux-sidebar-alt branch from 216dd72 to 71c1a57 Compare May 4, 2023 08:44
@laurent22
Copy link
Owner

Are you sure that would fix the issue of corrupted text?

@cas--
Copy link
Contributor Author

cas-- commented May 4, 2023

Absolutely this fixes the issue, replicated it here and faced the same problem with Logseq (logseq/logseq#9286) where I initially started with changing opacity until we found that any stacking context change would resolve it.

@laurent22
Copy link
Owner

Based on this comment it looks like there's a simpler fix?

#7506 (comment)

Are you able to confirm that it fixes the issue on your computer?

@cas--
Copy link
Contributor Author

cas-- commented May 16, 2023

Based on this comment it looks like there's a simpler fix?

As I already explained, everyone trying to use opacity 1 are degrading the intended opacity of menu items for Linux users vs other OS users.

My changes are intended to keep the opacity 0.9 and only apply to those elements that actually are affected.

@laurent22
Copy link
Owner

Ok let's merge as it seems to be a complex issue on Chromium and/or Electron and not clear when it will be fixed (and when we'll upgrade).

@laurent22 laurent22 merged commit 03424f7 into laurent22:dev May 29, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants