-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desktop: Improve sidebar workaround for Linux w/Intel GPU #8126
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
recheck |
Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users. The problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using `position: relative` to create a new one for affected text elements is an alternative workaround that has no effect on styling. Ref: laurent22#7506 Ref: laurent22#8000 Signed-off-by: Calum Lind <[email protected]>
216dd72
to
71c1a57
Compare
Are you sure that would fix the issue of corrupted text? |
Absolutely this fixes the issue, replicated it here and faced the same problem with Logseq (logseq/logseq#9286) where I initially started with changing opacity until we found that any stacking context change would resolve it. |
Based on this comment it looks like there's a simpler fix? Are you able to confirm that it fixes the issue on your computer? |
As I already explained, everyone trying to use opacity 1 are degrading the intended opacity of menu items for Linux users vs other OS users. My changes are intended to keep the opacity 0.9 and only apply to those elements that actually are affected. |
Ok let's merge as it seems to be a complex issue on Chromium and/or Electron and not clear when it will be fixed (and when we'll upgrade). |
Previous fixes set an opacity value of 1 which affects the sidebar styling for Linux users.
The problem of corrupted text in the sidebar seems to be related to stacking contexts therefore using
position: relative
to create a new one for affected text elements is an alternative workaround that has no effect on styling.Ref: #7506
Ref: #8000