Desktop: Replace Sidebar note count opacity with colorFaded2 #8298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linux users still reporting corrupted text in sidebar. This is a result of applying a new workaround in 03424f7. However it seems that testing with particular folder structure and icons was overlooked. The new issue is still a Chrome Intel GPU bug but because note count also sets opacity this is another factor requiring fixed. Perhaps the note count opacity was also the reason for the tag text corruption. Fixed by removing opacity from note count and using the more correct text styling of colorFaded2 which has 0.5 alpha channel, as used by AllNotes. Related: laurent22#7506 Fixes: laurent22#8297
|
Let's merge then, thanks for fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux users still reporting corrupted text in sidebar. This is a result
of applying a new workaround in 03424f7. However it seems that testing
with particular folder structure and icons was overlooked.
The new issue is still a Chrome Intel GPU bug but because note count also
sets opacity this is another factor requiring fixed. Perhaps the note
count opacity was also the reason for the tag text corruption.
Fixed by removing opacity from note count and using the more correct text
styling of colorFaded2 which has 0.5 alpha channel, as used by AllNotes.
Related: #7506
Fixes: #8297
Before
After