feat(store): add Storage.loadField for optimized loading of 32 bytes or less from storage #1512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 28efb9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Boffee
force-pushed
the
boffee/optimize-load-field
branch
2 times, most recently
from
aaaa78b to
a83e4dd
Compare
Boffee
force-pushed
the
boffee/optimize-load-field
branch
from
a83e4dd to
83f1828
Compare
alvrs
previously approved these changes
Sep 16, 2023
alvrs
changed the title
Co-authored-by: Kevin Ingersoll <[email protected]> Co-authored-by: alvrs <[email protected]>
Co-authored-by: alvarius <[email protected]>
Co-authored-by: alvrs <[email protected]>
holic
reviewed
Sep 16, 2023
packages/store/src/Storage.sol
Outdated
| * Load up to 32 bytes from storage at the given storagePointer and offset. | ||
| * The return value is left-aligned, the bytes beyond the length are not zeroed out, | ||
| * and the caller is expected to truncate as needed. | ||
| * The field can span up to two storage slots. |
There was a problem hiding this comment.
why? can we expand this comment to explain the case in which this happens? (I think it's because fields are packed tightly so two bytes20 fields together will take up a 32-byte slot + an extra 8 bytes of the next slot?)
There was a problem hiding this comment.
Yeah so since we tightly pack a field can span over two slots (eg the example you mentioned, or eg a bytes1 field followed by a bytes32 field), but since the max field length is 32 bytes it can maximally span two fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading field currently uses
Storage.load, which can load arbitrary number of slots. However, fields are always within bytes32.Storage.loadFieldremoves the logic for handling arbitrary lengths and allocating memory.This results in a 160 gas saving for fields that span a single slot and 80 gas saving for fields that span multiple slots. Decoding will also be cheaper because it would simple type casting.
Storage.loadFieldshould be used forgetStaticFieldoncegetFieldis split intogetStaticFieldandgetDynamicField.