feat(store): compute FieldLayout at compile time #1508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c956ca The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Boffee
changed the title
holic
reviewed
Sep 15, 2023
| @@ -32,9 +36,7 @@ struct Dynamics1Data { | |||
| library Dynamics1 { | |||
| /** Get the table values' field layout */ | |||
| function getFieldLayout() internal pure returns (FieldLayout) { | |||
There was a problem hiding this comment.
seems fine for completeness (so the methods match what you can get from the Tables table), if it's not used anywhere it's also not included in the bytecode
There was a problem hiding this comment.
I don't know why anyone would choose the less efficient one (function call) over the more efficient one though (importing the _fieldLayout directly)
alvrs
reviewed
Sep 15, 2023
alvrs
reviewed
Sep 15, 2023
alvrs
reviewed
Sep 15, 2023
alvrs
previously approved these changes
Sep 16, 2023
alvrs
approved these changes
Sep 16, 2023
alvrs
changed the title
alvrs
added a commit
to Boffee/mud
that referenced
this pull request
Sep 16, 2023
Co-authored-by: alvarius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #1336
Fixes #1327
Computing FieldLayout bytes from schema field type array is expensive (~500 + 500 * # of schema fields). This change precomputes the FieldLayout offchain inside codegen and hardcodes the byte into the auto-generated table libraries.