feat(store): optimize storage location hash #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 22caf56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 28 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alvrs
reviewed
Sep 15, 2023
tableId are strings that the user define, not hashes. If this is used to resolve storage location a user can access any storage location by picking the right tableId
Boffee
force-pushed
the
boffee/optimize-storage-location-hash
branch
from
357a71f to
063e28d
Compare
alvrs
approved these changes
Sep 16, 2023
alvrs
added a commit
to Boffee/mud
that referenced
this pull request
Sep 16, 2023
Co-authored-by: alvrs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing storage location hash encodes all parameters using
abi.encodeand hashes the result withkeccak256. The 2 optimizations are:keyTupleandtableId) outside of the hash and xor against the hash.abi.encodePackedbecause it produces a shorter encoding which reduces the gas cost forkeccak256.