Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(e2e): actually sync from MODE in e2e test #1110

Closed
wants to merge 3 commits into from
Closed

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jul 5, 2023

  • turns out the end-to-end tests were never actually syncing from MODE because the cacheThreshold was too high (so the client would always fall back to syncing from the local cache)
  • this PR fixes that, and also checks for an additional MODE error that is logged as a warning

@alvrs alvrs requested a review from holic as a code owner July 5, 2023 21:30
@changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2023

⚠️ No Changeset found

Latest commit: 58de62a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 1719618 to 0269bf5 Compare July 5, 2023 22:55
@alvrs alvrs force-pushed the alvrs/actual-e2e branch from 48cc664 to 58de62a Compare July 5, 2023 22:55
Base automatically changed from alvrs/abi-types-to-schema to main July 5, 2023 22:59
@alvrs alvrs marked this pull request as draft July 14, 2023 10:49
@alvrs
Copy link
Member Author

alvrs commented Aug 11, 2023

closing since we replaced the MODE e2e tests with e2e test for the new indexer

@alvrs alvrs closed this Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant