feat(protocol-parser): add abiTypesToSchema #1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
alvrs
commented
Jul 3, 2023
alvrs
commented
- add util to sort a list of abi types into a Schema object (with staticFields and dynamicFields)
🦋 Changeset detectedLatest commit: 412864e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This was referenced Jul 3, 2023
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
alvrs
force-pushed
the
alvrs/encode-key-tuple
branch
from
3492285 to
bb79f48
Compare
alvrs
force-pushed
the
alvrs/abi-types-to-schema
branch
from
61c8bb7 to
9342865
Compare
holic
reviewed
Jul 4, 2023
| import { DynamicAbiType, SchemaAbiType, StaticAbiType, isDynamicAbiType } from "@latticexyz/schema-type"; | ||
| import { Schema } from "./common"; | ||
|
|
||
| export function abiTypesToSchema(abiTypes: SchemaAbiType[]): Schema { |
There was a problem hiding this comment.
love that this is a hint towards order-preserving schemas (instead of restricted to static-then-dynamic) 👀
holic
previously approved these changes
Jul 4, 2023
alvrs
force-pushed
the
alvrs/encode-key-tuple
branch
from
bb79f48 to
1ca9345
Compare
alvrs
force-pushed
the
alvrs/abi-types-to-schema
branch
from
9342865 to
03b57ec
Compare
alvrs
force-pushed
the
alvrs/encode-key-tuple
branch
from
1ca9345 to
90a48c5
Compare
alvrs
force-pushed
the
alvrs/abi-types-to-schema
branch
from
03b57ec to
7682320
Compare
alvrs
force-pushed
the
alvrs/encode-key-tuple
branch
from
90a48c5 to
935011b
Compare
alvrs
force-pushed
the
alvrs/abi-types-to-schema
branch
from
7682320 to
1719618
Compare
alvrs
force-pushed
the
alvrs/abi-types-to-schema
branch
from
1719618 to
0269bf5
Compare
|
merging since nothing changed since last approval except adding a changeset |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.