Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(e2e): add test cases for dynamic data #1098

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

test(e2e): add test cases for dynamic data #1098

wants to merge 9 commits into from

Conversation

alvrs
Copy link
Member

@alvrs alvrs commented Jul 3, 2023 •
edited
Loading

  • adds more test data, including dynamic data

@alvrs alvrs requested a review from holic as a code owner July 3, 2023 15:29
@changeset-bot
Copy link

changeset-bot bot commented Jul 3, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: a46fe53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

This was referenced Jul 3, 2023
Merged
Merged
Merged
@alvrs
Copy link
Member Author

alvrs commented Jul 3, 2023 •
edited
Loading

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@alvrs alvrs marked this pull request as draft July 3, 2023 15:33
holic
holic reviewed Jul 3, 2023
View reviewed changes
e2e/packages/sync-test/data/encodeTestData.ts Outdated
: undefined
) as EncodedData<typeof testData>;
}

function abiTypeArrayToSchema(abiTypes: SchemaAbiType[]): Schema {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
function abiTypeArrayToSchema(abiTypes: SchemaAbiType[]): Schema {
function abiTypesToSchema(abiTypes: SchemaAbiType[]): Schema {

holic
holic reviewed Jul 3, 2023
View reviewed changes
e2e/packages/sync-test/data/encodeTestData.ts Outdated
else staticFields.push(abiType);
}
return { staticFields, dynamicFields };
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this could be useful to have in protocol-parser

@alvrs alvrs force-pushed the alvrs/e2e-testcases branch from 9346c1b to fcb84ac Compare July 3, 2023 16:06
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 225b5db to 2ec91c5 Compare July 3, 2023 16:06
@alvrs alvrs force-pushed the alvrs/e2e-testcases branch from fcb84ac to 96869f4 Compare July 3, 2023 17:35
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 2ec91c5 to 7bb422e Compare July 3, 2023 17:35
@alvrs alvrs force-pushed the alvrs/e2e-testcases branch from 96869f4 to 3631c5c Compare July 3, 2023 17:43
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 7bb422e to 58a757b Compare July 3, 2023 17:43
@alvrs alvrs changed the base branch from alvrs/e2e-testcases to alvrs/abi-types-to-schema July 3, 2023 19:27
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 30c100d to 435c03f Compare July 3, 2023 19:27
This was referenced Jul 3, 2023
Merged
Merged
@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 61c8bb7 to 9342865 Compare July 3, 2023 19:32
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 435c03f to 7f9ff12 Compare July 3, 2023 19:32
@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 9342865 to 03b57ec Compare July 4, 2023 11:55
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 3348d7c to 50c6dc3 Compare July 4, 2023 11:55
@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 03b57ec to 7682320 Compare July 4, 2023 12:17
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from 50c6dc3 to e3cb97a Compare July 4, 2023 12:17
@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 7682320 to 1719618 Compare July 5, 2023 21:30
@alvrs alvrs mentioned this pull request Jul 5, 2023
Closed
@alvrs alvrs force-pushed the alvrs/abi-types-to-schema branch from 1719618 to 0269bf5 Compare July 5, 2023 22:55
@alvrs alvrs force-pushed the alvrs/e2e-testcases-dynamics branch from e3cb97a to a46fe53 Compare July 5, 2023 22:55
Base automatically changed from alvrs/abi-types-to-schema to main July 5, 2023 22:59
@dk1a dk1a mentioned this pull request Jul 10, 2023
Open
47 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@holic holic holic left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvrs @holic