[5.8] Use the getDirty method on insert instead of getAttributes #25602
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same as #25559, except this time targeting new version as you said you wouldn't change something like this on a point release.
Below is a comment from previous PR:
In #25349 performInsert() was changed to use getAttributes() instead of accessing $attributes property directly, thus having more similar behavior to performUpdate().
I think it is better to use getDirty() in performInsert() as well.
Currently if we override getAttributes() method and return additional property the insert is going to fail, while update can pass if we override originalIsEquivalent() and return true for that additional property.