[5.5] Use the getAttributes method on insert #25349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the performInsert method to use getAttributes instead of accessing the property directly.
ollieread
changed the title
This was referenced Sep 10, 2018
EspadaV8
pushed a commit
to intellihr/framework
that referenced
this pull request
Jan 28, 2021
Update the performInsert method to use getAttributes instead of accessing the property directly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performInsert() method grabs the attributes property directly without using getAttributes(). The performUpdate() method uses getAttributes().
As far as I can see, there are no reasons that this method can't be called on insert, because if the $attributes property is set and populated, getAttributes() returns the values.
This will force Eloquent to honour its own API and help anyone that overrides this method for any reason.