[5.7] Use the getDirty method on insert instead of getAttributes

[kirba]

In #25349 performInsert() was changed to use getAttributes() instead of accessing $attributes property directly, thus having more similar behavior to performUpdate().

I think it is better to use getDirty() in performInsert() as well.

Currently if we override getAttributes() method and return additional property the insert is going to fail, while update can pass if we override originalIsEquivalent() and return true for that additional property.

[taylorotwell]

No way that I'm changing this on a point release 😄

[kirba]

should I send a PR to master or you don't like this at all?

[deleugpn]

It's unlikely that you're going to get an answer to a closed issue since Taylor works by going through PRs on a daily basis.
His comment only indicates that this is too much of a risk to merge and release, so you can send it to master to be considered whether it should go to 5.8 or not.

[kirba]

Thanks, I have created a new PR to master