feat(hints): add NewHint#26 #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
added
the
whitelisted-hint
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
Oppen
approved these changes
Apr 14, 2023
MegaRedHand
force-pushed
the
newhint27-ec-double-assign-new-x
branch
from
741a208 to
6a5aede
Compare
MegaRedHand
force-pushed
the
newhint26-verify-zero-v3
branch
from
34db699 to
7553821
Compare
Codecov Report
@@ Coverage Diff @@
## main #992 +/- ##
=======================================
Coverage 97.76% 97.77%
=======================================
Files 75 75
Lines 31196 31237 +41
=======================================
+ Hits 30500 30541 +41
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
reviewed
Apr 17, 2023
Oppen
approved these changes
Apr 17, 2023
Oppen
approved these changes
Apr 17, 2023
pefontana
reviewed
Apr 17, 2023
src/hint_processor/builtin_hint_processor/builtin_hint_processor_definition.rs
Outdated
Show resolved
Hide resolved
MegaRedHand
force-pushed
the
newhint26-verify-zero-v3
branch
from
1854c68 to
67477d9
Compare
|
Rebased to main and addressed comment in 67477d9 |
Oppen
approved these changes
Apr 17, 2023
pefontana
approved these changes
Apr 17, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#26 * Update changelog * Change assert_matches for assert + is_ok * Get and insert SECP_P from scope where applicable * Appease clippy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends: #990
This PR adds the missing hint NewHint#26, now known as
VERIFY_ZERO_EXTERNAL_SECP.