-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#27 #990
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 14, 2023 18:12
pefontana
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 14, 2023
MegaRedHand
force-pushed
the
newhint27-ec-double-assign-new-x
branch
from
April 14, 2023 20:31
610f170
to
741a208
Compare
Oppen
approved these changes
Apr 14, 2023
Some of the entries were being repeated when merging changes, and were also originally misplaced in the 0.3.0-rc1 section
MegaRedHand
force-pushed
the
newhint27-ec-double-assign-new-x
branch
from
April 15, 2023 14:28
741a208
to
6a5aede
Compare
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
==========================================
- Coverage 97.76% 97.76% -0.01%
==========================================
Files 75 75
Lines 31155 31154 -1
==========================================
- Hits 30459 30458 -1
Misses 696 696
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
juanbono
approved these changes
Apr 17, 2023
Oppen
approved these changes
Apr 17, 2023
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#27 * Update changelog * Fix changelog Some of the entries were being repeated when merging changes, and were also originally misplaced in the 0.3.0-rc1 section * Make hint codes public
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Depends: #989This PR adds the missing hint NewHint#27, now known as
EC_DOUBLE_ASSIGN_NEW_X_V2
. It also renamesEC_DOUBLE_ASSIGN_NEW_X
toEC_DOUBLE_ASSIGN_NEW_X_V1
.