-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(hints): add NewHint#23 #996
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MegaRedHand
requested review from
igaray,
Oppen,
fmoletta,
entropidelic,
juanbono,
pefontana and
Juan-M-V
as code owners
April 17, 2023 13:59
Oppen
approved these changes
Apr 17, 2023
Codecov Report
@@ Coverage Diff @@
## main #996 +/- ##
=======================================
Coverage 98.01% 98.02%
=======================================
Files 75 75
Lines 31297 31312 +15
=======================================
+ Hits 30677 30693 +16
+ Misses 620 619 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Oppen
approved these changes
Apr 17, 2023
juanbono
approved these changes
Apr 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
MegaRedHand
added
the
whitelisted-hint
Implementation of hint on whitelist directory
label
Apr 17, 2023
Oppen
approved these changes
Apr 17, 2023
Oppen
approved these changes
Apr 17, 2023
Benchmark Results for unmodified programs 🚀
|
This should make the codecov patch check pass.
kariy
pushed a commit
to dojoengine/cairo-rs
that referenced
this pull request
Jun 23, 2023
* Add NewHint#23 * Update changelog * Make hint codes public * Get and insert SECP_P from/into exec_scope in hint * Fix test * Change assert_matches for assert This should make the codecov patch check pass. --------- Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the missing hint NewHint#23, now known as
IS_ZERO_ASSIGN_SCOPE_VARS_EXTERNAL_SECP
. The functionality forimport SECP_P
is in #992, but this PR can be merged before it.