Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hints): add NewHint#23 #996

Merged
merged 11 commits into from
Apr 18, 2023
Merged

feat(hints): add NewHint#23 #996

merged 11 commits into from
Apr 18, 2023

Conversation

MegaRedHand
Copy link
Contributor

@MegaRedHand MegaRedHand commented Apr 17, 2023

Description

This PR adds the missing hint NewHint#23, now known as IS_ZERO_ASSIGN_SCOPE_VARS_EXTERNAL_SECP. The functionality for import SECP_P is in #992, but this PR can be merged before it.

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #996 (aa9eecd) into main (a993318) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #996   +/-   ##
=======================================
  Coverage   98.01%   98.02%           
=======================================
  Files          75       75           
  Lines       31297    31312   +15     
=======================================
+ Hits        30677    30693   +16     
+ Misses        620      619    -1     
Impacted Files Coverage Δ
...int_processor/builtin_hint_processor_definition.rs 98.78% <100.00%> (+<0.01%) ⬆️
...ocessor/builtin_hint_processor/secp/field_utils.rs 99.16% <100.00%> (+0.31%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MegaRedHand MegaRedHand added the whitelisted-hint Implementation of hint on whitelist directory label Apr 17, 2023
@Oppen Oppen enabled auto-merge April 17, 2023 15:13
@MegaRedHand MegaRedHand disabled auto-merge April 17, 2023 18:47
@Oppen Oppen enabled auto-merge April 17, 2023 19:35
@github-actions
Copy link

github-actions bot commented Apr 17, 2023

Benchmark Results for unmodified programs 🚀

Command Mean [s] Min [s] Max [s] Relative
base blake2s_integration_benchmark 2.774 ± 0.032 2.742 2.845 1.00 ± 0.02
head blake2s_integration_benchmark 2.766 ± 0.032 2.739 2.829 1.00
Command Mean [s] Min [s] Max [s] Relative
base compare_arrays_200000 3.367 ± 0.030 3.335 3.424 1.01 ± 0.01
head compare_arrays_200000 3.332 ± 0.013 3.315 3.355 1.00
Command Mean [s] Min [s] Max [s] Relative
base dict_integration_benchmark 2.522 ± 0.007 2.513 2.535 1.00
head dict_integration_benchmark 2.524 ± 0.025 2.502 2.571 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base factorial_multirun 4.078 ± 0.015 4.062 4.114 1.00
head factorial_multirun 4.102 ± 0.022 4.073 4.147 1.01 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base fibonacci_1000_multirun 3.248 ± 0.019 3.229 3.297 1.00
head fibonacci_1000_multirun 3.254 ± 0.013 3.237 3.277 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base integration_builtins 3.321 ± 0.018 3.299 3.350 1.00 ± 0.01
head integration_builtins 3.310 ± 0.014 3.299 3.341 1.00
Command Mean [s] Min [s] Max [s] Relative
base keccak_integration_benchmark 3.006 ± 0.012 2.988 3.029 1.00
head keccak_integration_benchmark 3.014 ± 0.024 2.991 3.077 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base linear_search 3.511 ± 0.026 3.485 3.566 1.01 ± 0.02
head linear_search 3.493 ± 0.054 3.463 3.642 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_cmp_and_pow_integration_benchmark 2.950 ± 0.053 2.915 3.088 1.01 ± 0.02
head math_cmp_and_pow_integration_benchmark 2.925 ± 0.025 2.913 2.995 1.00
Command Mean [s] Min [s] Max [s] Relative
base math_integration_benchmark 2.653 ± 0.018 2.635 2.694 1.00
head math_integration_benchmark 2.654 ± 0.024 2.628 2.696 1.00 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
base memory_integration_benchmark 2.336 ± 0.021 2.316 2.386 1.01 ± 0.01
head memory_integration_benchmark 2.317 ± 0.018 2.298 2.361 1.00
Command Mean [s] Min [s] Max [s] Relative
base operations_with_data_structures_benchmarks 2.368 ± 0.009 2.357 2.382 1.01 ± 0.00
head operations_with_data_structures_benchmarks 2.339 ± 0.007 2.329 2.349 1.00
Command Mean [s] Min [s] Max [s] Relative
base pedersen 3.334 ± 0.006 3.327 3.347 1.00 ± 0.00
head pedersen 3.329 ± 0.004 3.323 3.334 1.00
Command Mean [s] Min [s] Max [s] Relative
base poseidon_integration_benchmark 1.481 ± 0.007 1.472 1.496 1.00 ± 0.01
head poseidon_integration_benchmark 1.477 ± 0.005 1.468 1.487 1.00
Command Mean [s] Min [s] Max [s] Relative
base secp_integration_benchmark 2.627 ± 0.005 2.620 2.638 1.00
head secp_integration_benchmark 2.633 ± 0.005 2.625 2.640 1.00 ± 0.00
Command Mean [s] Min [s] Max [s] Relative
base set_integration_benchmark 1.823 ± 0.022 1.806 1.879 1.01 ± 0.02
head set_integration_benchmark 1.802 ± 0.028 1.782 1.877 1.00
Command Mean [s] Min [s] Max [s] Relative
base uint256_integration_benchmark 4.124 ± 0.013 4.107 4.141 1.00 ± 0.00
head uint256_integration_benchmark 4.112 ± 0.014 4.094 4.136 1.00

@Oppen Oppen added this pull request to the merge queue Apr 18, 2023
Merged via the queue into main with commit 8760345 Apr 18, 2023
@Oppen Oppen deleted the newhint23-is_zero branch April 18, 2023 15:45
kariy pushed a commit to dojoengine/cairo-rs that referenced this pull request Jun 23, 2023
* Add NewHint#23

* Update changelog

* Make hint codes public

* Get and insert SECP_P from/into exec_scope in hint

* Fix test

* Change assert_matches for assert

This should make the codecov patch check pass.

---------

Co-authored-by: Mario Rugiero <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
whitelisted-hint Implementation of hint on whitelist directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants