Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support StatefulSet for Module Deployment ReadinessCheck #1649

Closed
3 tasks done
jeremyharisch opened this issue Jun 28, 2024 · 0 comments · Fixed by kyma-project/template-operator#224, #1713 or kyma-project/template-operator#226
Closed
3 tasks done

Support StatefulSet for Module Deployment ReadinessCheck #1649

jeremyharisch opened this issue Jun 28, 2024 · 0 comments · Fixed by kyma-project/template-operator#224, #1713 or kyma-project/template-operator#226
Assignees
@nesmabadr
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@jeremyharisch
Copy link
Contributor

jeremyharisch commented Jun 28, 2024 •
edited by nesmabadr
Loading

Related epic: #1471

Description

With #1628 the business and deployment logic have been separated and the state of a Manifest is now based on the Deployment status.

Since a StatefulSet is also a valid resource for a Kyma Module, it should also be considered for the ReadyCheck.

Reasons

  • StatefulSet valid resource for a module Operator

Acceptance Criteria

Feature Testing

  • e2e testing
@jeremyharisch jeremyharisch added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 28, 2024
@jeremyharisch jeremyharisch mentioned this issue Jun 28, 2024
Merged
@jeremyharisch jeremyharisch changed the title Feature Title Support StatefulSet for Module Deployment ReadinessCheck Jul 2, 2024
@nesmabadr nesmabadr self-assigned this Jul 19, 2024
@nesmabadr nesmabadr mentioned this issue Jul 22, 2024
Merged
@nesmabadr nesmabadr linked a pull request Jul 22, 2024 that will close this issue
feat: Add Kustomize profile for StatefulSet resource kyma-project/template-operator#224
Merged
kyma-bot pushed a commit to kyma-project/template-operator that referenced this issue Jul 24, 2024
@nesmabadr
feat: Add Kustomize profile for StatefulSet resource (#224)
2716d72 
<!-- Thank you for your contribution. Before you submit the pull
request:
1. Follow contributing guidelines, templates, the recommended Git
workflow, and any related documentation.
2. Read and submit the required Contributor Licence Agreements
(https://github.com/kyma-project/community/blob/main/CONTRIBUTING.md#agreements-and-licenses).
3. Test your changes and attach their results to the pull request.
4. Update the relevant documentation.

If the pull request requires a decision, follow the [decision-making
process](https://github.com/kyma-project/community/blob/main/governance.md)
and replace the PR template with the [decision record
template](https://github.com/kyma-project/community/blob/main/.github/ISSUE_TEMPLATE/decision-record.md).
-->

**Description**

Changes proposed in this pull request:

- Add new Kustomize profile for StatefulSet resource
- Add related make targets

**Related issue(s)**
kyma-project/lifecycle-manager#1649
@nesmabadr nesmabadr reopened this Jul 24, 2024
@nesmabadr nesmabadr mentioned this issue Jul 24, 2024
Merged
@nesmabadr nesmabadr removed their assignment Jul 24, 2024
@jeremyharisch jeremyharisch self-assigned this Jul 25, 2024
@nesmabadr nesmabadr linked a pull request Jul 26, 2024 that will close this issue
chore: Remove unneeded default directory kyma-project/template-operator#226
Merged
@lindnerby lindnerby assigned nesmabadr and unassigned jeremyharisch Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nesmabadr nesmabadr

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
2 participants
@nesmabadr @jeremyharisch