Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Kustomize profile for StatefulSet resource #224

Merged

Conversation

nesmabadr
Copy link
Contributor

@nesmabadr nesmabadr commented Jul 22, 2024

Description

Changes proposed in this pull request:

  • Add new Kustomize profile for StatefulSet resource
  • Add related make targets

Related issue(s)
kyma-project/lifecycle-manager#1649

@nesmabadr nesmabadr requested review from a team as code owners July 22, 2024 11:51
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 22, 2024
@nesmabadr nesmabadr changed the title feat: Add Kustomize profile for Statefulset instead of Deployment resource feat: Add Kustomize profile for Statefulset resource Jul 22, 2024
@nesmabadr nesmabadr changed the title feat: Add Kustomize profile for Statefulset resource feat: Add Kustomize profile for StatefulSet resource Jul 22, 2024
@jeremyharisch jeremyharisch self-assigned this Jul 23, 2024
Copy link
Contributor

@jeremyharisch jeremyharisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left code for code enhancements. Functionality wise, it's fine.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
config/rbac/role.yaml Show resolved Hide resolved
config/statefulset/kustomization.yaml Outdated Show resolved Hide resolved
@nesmabadr nesmabadr requested a review from jeremyharisch July 23, 2024 14:40
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 24, 2024
@kyma-bot kyma-bot merged commit 2716d72 into kyma-project:main Jul 24, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support StatefulSet for Module Deployment ReadinessCheck
4 participants