Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Separate business status from module status #1628

Merged
merged 33 commits into from
Jul 2, 2024
Merged

feat: Separate business status from module status #1628

merged 33 commits into from
Jul 2, 2024

Conversation

jeremyharisch
Copy link
Contributor

@jeremyharisch jeremyharisch commented Jun 12, 2024 •
edited
Loading

Description

Implements #1554

Changes proposed in this pull request:

  • New Status behaviour for Manifest CRs:
    • If the Module defined in the Manifest CR is applied successfully and is running, the status is Ready.
    • If the Module is still being applied or starting, the status is Processing.
    • If the Module fails to start or the Manifest application fails, the status is Error.
    • If the Manifest CR is marked for deletion, the status is Deleted.
  • Covered new behaviour in E2E Test

Related issue(s)

Resolves #1554

@jeremyharisch jeremyharisch requested a review from a team as a code owner June 12, 2024 12:57
@jeremyharisch jeremyharisch added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Jun 12, 2024
@jeremyharisch jeremyharisch linked an issue Jun 12, 2024 that may be closed by this pull request
Separate business and module statuses #1471
Closed
1 task
@kyma-bot kyma-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 12, 2024
@jeremyharisch jeremyharisch changed the title Separate Busniess from KLM Logic Separate business status from module status Jun 12, 2024
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 12, 2024
@jeremyharisch jeremyharisch changed the title Separate business status from module status feat: Separate business status from module status Jun 12, 2024
@jeremyharisch jeremyharisch mentioned this pull request Jun 26, 2024
Merged
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 26, 2024
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 26, 2024
@jeremyharisch jeremyharisch mentioned this pull request Jun 28, 2024
Closed
3 tasks
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 28, 2024
@jeremyharisch jeremyharisch requested a review from ruanxin June 28, 2024 13:58
grego952
grego952 reviewed Jul 1, 2024
View reviewed changes
docs/technical-reference/api/manifest-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/manifest-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/manifest-cr.md Outdated Show resolved Hide resolved
docs/technical-reference/api/manifest-cr.md Outdated Show resolved Hide resolved
@jeremyharisch jeremyharisch requested review from ruanxin and grego952 July 1, 2024 15:36
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jul 2, 2024
@kyma-bot kyma-bot merged commit 130e98f into kyma-project:main Jul 2, 2024
42 checks passed
@jeremyharisch jeremyharisch deleted the newStateLogic branch July 12, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IwonaLanger IwonaLanger IwonaLanger approved these changes

@ruanxin ruanxin ruanxin approved these changes

@grego952 grego952 Awaiting requested review from grego952

Assignees

@ruanxin ruanxin

@IwonaLanger IwonaLanger

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop aggregate module cr state into manifest cr Separate business and module statuses
5 participants
@jeremyharisch @ruanxin @grego952 @IwonaLanger @kyma-bot