Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix all infos & warnings from istioctl analyze command #11686

Closed
strekm opened this issue Jul 14, 2021 · 15 comments
Closed

Fix all infos & warnings from istioctl analyze command #11686

strekm opened this issue Jul 14, 2021 · 15 comments
Assignees
Labels
area/service-mesh Issues or PRs related to service-mesh estimate: 3 kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@strekm
Copy link
Contributor

strekm commented Jul 14, 2021

Description

Clear out an output of istioctl analyze -n kyma-system and istioctl analyze -n kyma-integration commands. At this moment there are bunch of infos about wrongly named ports and few warnings related to annotations.
kyma-integration.txt
kyma-system.txt

Reasons

Improve visibility of istio related issues, improve troubleshooting & debugging

Attachments
kyma-integration.txt
kyma-system.txt

@strekm strekm added kind/feature Categorizes issue or PR as related to a new feature. area/service-mesh Issues or PRs related to service-mesh labels Jul 14, 2021
@strekm strekm added this to the 2.0-m2 milestone Jul 14, 2021
@strekm strekm modified the milestones: 2.0-m2, 2.0-m3 Sep 2, 2021
@strekm strekm modified the milestones: 2.0-m3, 2.0-m4 Oct 13, 2021
@pbochynski pbochynski modified the milestones: 2.0-m4, 2.1 Oct 28, 2021
@ghost
Copy link

ghost commented Dec 27, 2021

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@mjakobczyk
Copy link
Contributor

It seems that some of the port names connected with Tracing can not be changed on Kyma side as they are defined in jaeger-operator itself.
As a result, following infos would not be addressed:

Info [IST0118] (Service tracing-jaeger-agent.kyma-system) Port name config-rest (port: 5778, targetPort: 5778) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector-headless.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.

@cnvergence
Copy link
Contributor

cnvergence commented Apr 1, 2022

For the duplicate certificate in the application-connector gateway, we won't push any changes

Warning [IST0138] (Gateway kyma-system/kyma-gateway-application-connector) Duplicate certificate in multiple gateways [kyma-system/kyma-gateway-application-connector kyma-system/kyma-gateway] may cause 404s if clients re-use HTTP2 connections.

Please see the explanation here

@cnvergence
Copy link
Contributor

cnvergence commented Apr 5, 2022

The same goes for the annotations in jaeger controlled by tracing-operator

Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/inject can only be applied to Pod
Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/rewriteAppHTTPProbers can only be applied to Pod

Currently it is not possible to properly set those annotations

@cnvergence
Copy link
Contributor

cnvergence commented Apr 15, 2022

I have opened the issue in the jaeger-operator helm chart

@cnvergence
Copy link
Contributor

cnvergence commented Apr 15, 2022

@strekm strekm modified the milestones: 2.2, 2.3, Future May 16, 2022
@cnvergence
Copy link
Contributor

cnvergence commented May 30, 2022

PRs to jaeger-operator were merged and released with 1.34.0, but we are blocked by this issue in the helm chart

@cnvergence
Copy link
Contributor

Helm charts of jaeger-operator were fixed

This issue can be closed after bumping jaeger-operator to 1.34.0 version

@github-actions
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 14, 2022
@cnvergence cnvergence removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 17, 2022
@github-actions
Copy link

This issue has been automatically marked as stale due to the lack of recent activity. It will soon be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 17, 2022
@werdes72 werdes72 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 19, 2022
@johgoe
Copy link
Contributor

johgoe commented Nov 13, 2022

Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/inject can only be applied to Pod
Warning [IST0107] (Deployment kyma-system/tracing-jaeger) Misplaced annotation: sidecar.istio.io/rewriteAppHTTPProbers can only be applied to Pod
Info [IST0118] (Service kyma-system/monitoring-kube-state-metrics) Port name metrics (port: 8081, targetPort: 8081) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/telemetry-operator-webhook) Port name  (port: 443, targetPort: 9443) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/tracing-jaeger-collector-headless) Port name otlp-grpc (port: 4317, targetPort: 4317) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/tracing-jaeger-collector-headless) Port name otlp-http (port: 4318, targetPort: 4318) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/tracing-jaeger-collector) Port name otlp-grpc (port: 4317, targetPort: 4317) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/tracing-jaeger-collector) Port name otlp-http (port: 4318, targetPort: 4318) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service kyma-system/tracing-metrics) Port name cr-metrics (port: 8686, targetPort: 8686) doesn't follow the naming convention of Istio port.
Info [IST0135] (Deployment kyma-system/tracing-jaeger) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/alertmanager-monitoring-alertmanager-0) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/cluster-essentials-pod-preset-webhook-858f8d446f-58mvt) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/cluster-essentials-pod-preset-webhook-858f8d446f-zwpbf) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/eventing-nats-0) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/eventing-nats-1) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/eventing-nats-2) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/kiali-78d5479f95-jgvhm) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/logging-loki-0) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/monitoring-kube-state-metrics-858cd64f74-xp7bb) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/monitoring-operator-5566cf78-wxvn2) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/monitoring-prometheus-istio-server-54cfc5f7b5-5pgst) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/prometheus-monitoring-prometheus-0) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/serverless-ctrl-mngr-657b8cc46-mcrtd) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/serverless-webhook-svc-5c58cd8bcd-vqw2k) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/telemetry-operator-66f4f47ff7-426qq) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.
Info [IST0135] (Pod kyma-system/tracing-jaeger-679ddc6979-n5969) Annotation "sidecar.istio.io/inject" has been deprecated in favor of the "sidecar.istio.io/inject" label and may not work in future Istio versions.

@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 12, 2023
@videlov videlov removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 18, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically marked as stale due to the lack of recent activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Close this issue or PR with /close

If you think that I work incorrectly, kindly raise an issue with the problem.

/lifecycle stale

@kyma-bot kyma-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 19, 2023
@kyma-bot
Copy link
Contributor

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

@kyma-bot
Copy link
Contributor

@kyma-bot: Closing this issue.

In response to this:

This issue or PR has been automatically closed due to the lack of activity.
Thank you for your contributions.

This bot triages issues and PRs according to the following rules:

  • After 60d of inactivity, lifecycle/stale is applied
  • After 7d of inactivity since lifecycle/stale was applied, the issue is closed

You can:

  • Reopen this issue or PR with /reopen
  • Mark this issue or PR as fresh with /remove-lifecycle stale

If you think that I work incorrectly, kindly raise an issue with the problem.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@werdes72 werdes72 removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-mesh Issues or PRs related to service-mesh estimate: 3 kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

8 participants