-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add http- prefix to port names in collector and agent services #1862
Conversation
Signed-off-by: Karol Szwaj <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## main #1862 +/- ##
=======================================
Coverage 89.42% 89.42%
=======================================
Files 100 100
Lines 6118 6118
=======================================
Hits 5471 5471
Misses 471 471
Partials 176 176
Continue to review full report at Codecov.
|
hi @cnvergence, could you tell me how you produced those lines using
update: seems to be |
hey @frzifus, yes, it is |
Signed-off-by: Karol Szwaj [email protected]
Which problem is this PR solving?
Short description of the changes
Adding a prefix to service port names, resolves issues with istioctl
Potentially possible problems similar to this old issue.