Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http- prefix to port names in collector and agent services #1862

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

cnvergence
Copy link
Contributor

@cnvergence cnvergence commented Apr 19, 2022

Signed-off-by: Karol Szwaj [email protected]

Which problem is this PR solving?

Short description of the changes

Adding a prefix to service port names, resolves issues with istioctl

Info [IST0118] (Service tracing-jaeger-agent.kyma-system) Port name config-rest (port: 5778, targetPort: 5778) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector-headless.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.

Potentially possible problems similar to this old issue.

Copy link
Member

@frzifus frzifus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Collaborator

@rubenvp8510 rubenvp8510 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rubenvp8510 rubenvp8510 enabled auto-merge (squash) April 20, 2022 03:59
@codecov
Copy link

codecov bot commented Apr 20, 2022

Codecov Report

Merging #1862 (c79b056) into main (06bcef6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head c79b056 differs from pull request most recent head f5dcc97. Consider uploading reports for the commit f5dcc97 to get more accurate results

@@           Coverage Diff           @@
##             main    #1862   +/-   ##
=======================================
  Coverage   89.42%   89.42%           
=======================================
  Files         100      100           
  Lines        6118     6118           
=======================================
  Hits         5471     5471           
  Misses        471      471           
  Partials      176      176           
Impacted Files Coverage Δ
pkg/service/agent.go 100.00% <100.00%> (ø)
pkg/service/collector.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06bcef6...f5dcc97. Read the comment docs.

@frzifus
Copy link
Member

frzifus commented Oct 19, 2022

hi @cnvergence, could you tell me how you produced those lines using istioctl?

Info [IST0118] (Service tracing-jaeger-agent.kyma-system) Port name config-rest (port: 5778, targetPort: 5778) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector-headless.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.
Info [IST0118] (Service tracing-jaeger-collector.kyma-system) Port name c-tchan-trft (port: 14267, targetPort: 14267) doesn't follow the naming convention of Istio port.

update: seems to be istioctl analyze :)

@cnvergence
Copy link
Contributor Author

hey @frzifus, yes, it is istioctl analyze :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants