-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to set sidecar.istio.io Pod annotations in jaeger pod #355
Labels
bug
Something isn't working
Comments
The place of an overwrite |
this Operator values Did not add the sidecar.istio.io/inject: "true"` to the pod |
Adding those values will set annotations properly jaeger:
spec:
allInOne:
annotations:
sidecar.istio.io/inject: "true"
sidecar.istio.io/rewriteAppHTTPProbers: "true" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Currently, we are unable to add annotations properly to a Jaeger pod using Jaeger-operator.
To Reproduce
Applying those annotations in the values of Jaeger-operator helm chart.
This will result in the following
istioctl analyze
warnings:I tried then to apply them to the Pods, with those values:
The result was, that it did not update those annotations in the pods, instead, it got overwritten with
sidecar.istio.io/inject: "false"
annotationExpected behaviour
It should be possible to control Pod annotations on Jaeger pods controlled by Jaeger-operator.
Version (please complete the following information):
The text was updated successfully, but these errors were encountered: