-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: setting default Istio annotation in Pod instead of Deployment #1860
Fix: setting default Istio annotation in Pod instead of Deployment #1860
Conversation
054624c
to
dbfe277
Compare
Signed-off-by: Karol Szwaj <[email protected]>
dbfe277
to
6126133
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense to me. What do you think @rubenvp8510 ?
Signed-off-by: Karol Szwaj <[email protected]>
hey @frzifus, could you take a look again, please? |
Signed-off-by: Karol Szwaj <[email protected]>
Yep, it makes sense to me. |
Codecov Report
@@ Coverage Diff @@
## main #1860 +/- ##
==========================================
+ Coverage 89.42% 89.44% +0.01%
==========================================
Files 100 100
Lines 6118 6128 +10
==========================================
+ Hits 5471 5481 +10
Misses 471 471
Partials 176 176
Continue to review full report at Codecov.
|
@rubenvp8510 @frzifus I needed to update this branch, ptal |
sure |
Properly add istio annotation to Pod instead of Deployment.
Fixes
istioctl analyze
warningWhich problem is this PR solving?
Resolves: