Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix delete cluster action #3540

Merged
merged 20 commits into from
Dec 18, 2024
Merged

fix: Fix delete cluster action #3540

merged 20 commits into from
Dec 18, 2024

Conversation

akucharska
Copy link
Contributor

@akucharska akucharska commented Dec 16, 2024 •
edited
Loading

Description

Changes proposed in this pull request:

  • Fix delete cluster action

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

mrCherry97 and others added 20 commits November 20, 2024 11:11
@mrCherry97
feat: add rebase actions and add to test workflows (kyma-project#3488)
1b3b4aa 
* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows

* feat: add rebase actions and add to test workflows
@akucharska
fix: Truncated deep links (kyma-project#3484)
3dd2283 
* fix: truncated deep links

* Show buttons

* Fix separator and spacing

* Fix tests

* Fix tests

* Fix modules
@mrCherry97
feat(ghActions): don't run workflows on draft PRs (kyma-project#3492)
0c4ca06 
* feat(ghActions): don't run workflows on draft PRs

* I hope it works

* I hope it works
@akucharska
feat: Display modules status in the same way on all views (kyma-proje…
50122ae 
…ct#3501)

* feat: Display modules stasus the same way on all views

* Fix console errors
@akucharska
fix: Fix deployment status properly (kyma-project#3495)
04fdb72 
* Fix deployment status properly on deployments list,
 details and incluster overview

* Fix deployments card
@akucharska
fix-all-namespaces (kyma-project#3507)
ad76fef
@mrCherry97
feat(Modules): modules version adjustments to moduleCatalog changes (k…
0519973 
…yma-project#3500)

* feat: modules version adjustments to moduleCatalog changes

* adjust edit view

* adjust list view of the modules
@mrCherry97
fix(nodes): fix metrics for nodes (kyma-project#3516)
4d0f652 
* fix(nodes): fix metrics for nodes

* remove clgs

* cleanup

* too much of the cleanup

* I need to change my glasses
@akucharska
Fix fonts in safari (kyma-project#3509)
2e63290
@mrCherry97 @grego952
docs: adjust testing strategy to github actions and add new workflows (…
38a1415 
…kyma-project#3525)

* docs: adjust testing strategy to github actions and add new workflows

* Update docs/contributor/testing-strategy.md

Co-authored-by: Grzegorz Karaluch <[email protected]>

* Update docs/contributor/testing-strategy.md

Co-authored-by: Grzegorz Karaluch <[email protected]>

---------

Co-authored-by: Grzegorz Karaluch <[email protected]>
@chriskari
feat: custom busola extensions (kyma-project#3523)
463d5a9 
* feat: add proxyhandler to backend

* feat: adjust busola code to handle custom extensions

* feat: added example custom extension

* feat: rename folder

* feat: add docs

* feat: update docs

* feat: update docs

* feat: add more specific types

* feat: adjust to review comments

* adjust to comments
@mrCherry97
chore: override cookie and path-to-regexp packages in express (kyma-p…
622db81 
…roject#3527)

* chore: override path-to-regexp package in express

* chore: override cookie package in express

* add backend to paths for tests workflows
@mrCherry97
chore: add package-locks to exclude for checkmarx' (kyma-project#3528)
09205ea
@mrCherry97
chore(deps): bump express version (kyma-project#3530)
4158bbb
@pbochynski
fix: Loading custom script from blob (kyma-project#3531)
0742417
@mrCherry97
tests: fix cron job acc test (kyma-project#3526)
c20029c 
* tests: fix cron job acc test

* adjust acc workflow

* adjust acc workflow
@OliwiaGowor
Merge branch 'main' into ui5-migrate-v2
79fb867
@OliwiaGowor
Revert "Merge branch 'main' into ui5-migrate-v2"
0c6d5ab 
This reverts commit 79fb867, reversing
changes made to 5b7fd61.
@OliwiaGowor
fix: selected in lists (kyma-project#3539)
e10b457
@akucharska
Fix delete cluster action
3ce471a
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 16, 2024
@akucharska akucharska changed the title Fix delete cluster action fix: Fix delete cluster action Dec 16, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 17, 2024
@mrCherry97 mrCherry97 requested a review from a team as a code owner December 17, 2024 11:18
@mrCherry97 mrCherry97 force-pushed the ui5-migrate-v2 branch 2 times, most recently from e10b457 to 5b7fd61 Compare December 17, 2024 11:33
mrCherry97
mrCherry97 requested changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@mrCherry97 mrCherry97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR history is messed up, please fix to contain only commits related to your changes.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Dec 17, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Dec 18, 2024
@mrCherry97 mrCherry97 merged commit 049a830 into kyma-project:ui5-migrate-v2 Dec 18, 2024
26 of 63 checks passed
@mrCherry97 mrCherry97 deleted the delete-cluster branch December 18, 2024 08:03
OliwiaGowor pushed a commit to OliwiaGowor/busola that referenced this pull request Dec 20, 2024
@akucharska @OliwiaGowor
fix: Fix delete cluster action (kyma-project#3540)
2ade18b 
* Fix delete cluster action
@OliwiaGowor OliwiaGowor mentioned this pull request Dec 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskari chriskari chriskari approved these changes

@mrCherry97 mrCherry97 mrCherry97 approved these changes

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@OliwiaGowor OliwiaGowor Awaiting requested review from OliwiaGowor OliwiaGowor is a code owner

Assignees

@mrCherry97 mrCherry97

@chriskari chriskari

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@akucharska @mrCherry97 @chriskari @kyma-bot @pbochynski @OliwiaGowor