Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix delete cluster action #3540

Merged
merged 20 commits into from
Dec 18, 2024
Merged

fix: Fix delete cluster action #3540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1b3b4aa
feat: add rebase actions and add to test workflows (#3488)
mrCherry97 Nov 20, 2024
3dd2283
fix: Truncated deep links (#3484)
akucharska Nov 20, 2024
0c4ca06
feat(ghActions): don't run workflows on draft PRs (#3492)
mrCherry97 Nov 20, 2024
50122ae
feat: Display modules status in the same way on all views (#3501)
akucharska Nov 26, 2024
04fdb72
fix: Fix deployment status properly (#3495)
akucharska Dec 2, 2024
ad76fef
fix-all-namespaces (#3507)
akucharska Dec 2, 2024
0519973
feat(Modules): modules version adjustments to moduleCatalog changes (…
mrCherry97 Dec 3, 2024
4d0f652
fix(nodes): fix metrics for nodes (#3516)
mrCherry97 Dec 3, 2024
2e63290
Fix fonts in safari (#3509)
akucharska Dec 11, 2024
38a1415
docs: adjust testing strategy to github actions and add new workflows…
mrCherry97 Dec 11, 2024
463d5a9
feat: custom busola extensions (#3523)
chriskari Dec 12, 2024
622db81
chore: override cookie and path-to-regexp packages in express (#3527)
mrCherry97 Dec 12, 2024
09205ea
chore: add package-locks to exclude for checkmarx' (#3528)
mrCherry97 Dec 12, 2024
4158bbb
chore(deps): bump express version (#3530)
mrCherry97 Dec 12, 2024
0742417
fix: Loading custom script from blob (#3531)
pbochynski Dec 12, 2024
c20029c
tests: fix cron job acc test (#3526)
mrCherry97 Dec 12, 2024
79fb867
Merge branch 'main' into ui5-migrate-v2
OliwiaGowor Dec 13, 2024
0c6d5ab
Revert "Merge branch 'main' into ui5-migrate-v2"
OliwiaGowor Dec 13, 2024
e10b457
fix: selected in lists (#3539)
OliwiaGowor Dec 16, 2024
3ce471a
Fix delete cluster action
akucharska Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/shared/components/GenericList/components.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ export const HeaderRenderer = ({
<TableColumn
slot={`${slot}-${index}`}
key={typeof h === 'object' ? index : h}
popinDisplay="Block"
demandPopin={h === 'Popin' ? true : false}
minWidth={
Array.isArray(noHideFields) && noHideFields.length !== 0
? noHideFields.find(field => field === h)
Expand Down Expand Up @@ -135,7 +137,7 @@ const DefaultRowRenderer = ({
);

return (
<TableRow type="Active">
<TableRow type="Active" selected={isSelected}>
{cells}
{!!actions.length && actionsCell}
{displayArrow && (
Expand Down
5 changes: 4 additions & 1 deletion src/shared/components/ListActions/ListActions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,10 @@ const StandaloneAction = ({ action, entry }) => {
return (
<Button
data-testid={action.name.replace(' ', '').toLowerCase()}
onClick={() => action.handler(entry)}
onClick={e => {
e.stopPropagation();
action.handler(entry);
}}
className="list-actions__standalone"
design="Transparent"
icon={typeof icon === 'function' ? icon(entry) : icon}
Expand Down
Loading