Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix deployment status properly #3495

Merged
merged 2 commits into from
Dec 2, 2024
Merged

fix: Fix deployment status properly #3495

merged 2 commits into from
Dec 2, 2024

Conversation

akucharska
Copy link
Contributor

details and incluster overview

Description

Changes proposed in this pull request:

  • Fix deployment status properly on deployments list, details and in the cluster overview

Related issue(s)

Definition of done

  • The PR's title starts with one of the following prefixes:
    • feat: A new feature
    • fix: A bug fix
    • docs: Documentation only changes
    • refactor: A code change that neither fixes a bug nor adds a feature
    • test: Adding tests
    • chore: Maintainance changes to the build process or auxiliary tools, libraries, workflows, etc.
  • Related issues are linked. To link internal trackers, use the issue IDs like backlog#4567
  • Explain clearly why you created the PR and what changes it introduces
  • All necessary steps are delivered, for example, tests, documentation, merging

@kyma-bot kyma-bot added the cla: yes Indicates the PR's author has signed the CLA. label Nov 21, 2024
@akucharska akucharska linked an issue Nov 21, 2024 that may be closed by this pull request
Do not show deployment as healthy if the replica creation failed (i.e because of warden) #3472
Closed
@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 21, 2024
@mrCherry97 mrCherry97 assigned dbadura and OliwiaGowor and unassigned dbadura Nov 22, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Nov 26, 2024
@mrCherry97
Copy link
Contributor

/override tide

@kyma-bot
Copy link
Contributor

kyma-bot commented Dec 2, 2024

@mrCherry97: Overrode contexts on behalf of mrCherry97: tide

In response to this:

/override tide

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@mrCherry97 mrCherry97 merged commit 04fdb72 into kyma-project:main Dec 2, 2024
15 checks passed
@mrCherry97 mrCherry97 deleted the is-deployment-healthy branch December 2, 2024 07:40
pbochynski pushed a commit to pbochynski/busola that referenced this pull request Dec 6, 2024
@akucharska @pbochynski
fix: Fix deployment status properly (kyma-project#3495)
58c0632 
* Fix deployment status properly on deployments list,
 details and incluster overview

* Fix deployments card
OliwiaGowor pushed a commit to OliwiaGowor/busola that referenced this pull request Dec 20, 2024
@akucharska @OliwiaGowor
fix: Fix deployment status properly (kyma-project#3495)
1bf5f27 
* Fix deployment status properly on deployments list,
 details and incluster overview

* Fix deployments card
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OliwiaGowor OliwiaGowor OliwiaGowor approved these changes

@mrCherry97 mrCherry97 Awaiting requested review from mrCherry97 mrCherry97 is a code owner

@dbadura dbadura Awaiting requested review from dbadura dbadura is a code owner

@chriskari chriskari Awaiting requested review from chriskari chriskari is a code owner

Assignees

@OliwiaGowor OliwiaGowor

Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Do not show deployment as healthy if the replica creation failed (i.e because of warden)
5 participants
@akucharska @mrCherry97 @kyma-bot @OliwiaGowor @dbadura