publish: Parameterize CRI binary #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
|
/cc @brianmcarey The commit you already review in the past, but that was split out that PR |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brianmcarey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
lgtm
kubevirt-bot
added a commit
to kubevirt-bot/kubevirt
that referenced
this pull request
Mar 30, 2023
[c731ec1 Revert "Control-plane nodes which are marked as schedulable are also given worker role.](https://github.com/kubevirt/kubevirtci/pull/985)"](https://github.com/kubevirt/kubevirtci/pull/990) [9df5cab publish: Parameterize CRI binary](kubevirt/kubevirtci#989) [2e998c2 Control-plane nodes which are marked as schedulable are also given worker role.](kubevirt/kubevirtci#985) [58e2672 kind: amend env variable CONFIG_WORKER_CPU_MANAGER](kubevirt/kubevirtci#983) [2957a2f publish: Refactor script](kubevirt/kubevirtci#980) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support both podman and docker.