Control-plane nodes which are marked as schedulable are also given worker role. #985
Conversation
…rker role. Signed-off-by: prnaraya <[email protected]>
kubevirt-bot
added
the
dco-signoff: yes
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rmohr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
[2e998c2 Control-plane nodes which are marked as schedulable are also given worker role.](kubevirt/kubevirtci#985) [58e2672 kind: amend env variable CONFIG_WORKER_CPU_MANAGER](kubevirt/kubevirtci#983) [2957a2f publish: Refactor script](kubevirt/kubevirtci#980) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
| # Worker nodes might lack worker role label. | ||
| master_nodes=$(_get_nodes | grep -i $MASTER_NODES_PATTERN | awk '{print $1}') | ||
| for node in ${master_nodes[@]}; do | ||
| # removing NoSchedule taint if is there | ||
| if _kubectl taint nodes $node node-role.kubernetes.io/master:NoSchedule-; then | ||
| _kubectl label node $node kubevirt.io/schedulable=true | ||
| _kubectl label node $node node-role.kubernetes.io/worker="" |
There was a problem hiding this comment.
This can break SR-IOV
see please kubevirt/kubevirt#9505 (comment)
|
PRs which are related to sig-network should be verified by sig-network as well please FYI We removed kind presubmit here so it didnt catch it (assuming it is a real bug, we will soon find out) |
|
Note that it fails, even before reaching the scenario I think will happen as well We don't have automation for kind-1.23 / kind-1.23-sriov, and should drop them because they are too old Suggested a possible quick solution in the mentioned PR. We might still have the presubmit of kind SR-IOV that can be used manually whenever needed |
…given worker role. (kubevirt#985)" This reverts commit 2e998c2. Signed-off-by: Or Shoval <[email protected]>
|
Please see #990 |
…given worker role. (kubevirt#985)" This reverts commit 2e998c2.
…given worker role. (#985)" (#990) This reverts commit 2e998c2. Signed-off-by: Or Shoval <[email protected]>
|
Hi, I think that the easiest solution, Opened #991 |
[c731ec1 Revert "Control-plane nodes which are marked as schedulable are also given worker role.](https://github.com/kubevirt/kubevirtci/pull/985)"](https://github.com/kubevirt/kubevirtci/pull/990) [9df5cab publish: Parameterize CRI binary](kubevirt/kubevirtci#989) [2e998c2 Control-plane nodes which are marked as schedulable are also given worker role.](kubevirt/kubevirtci#985) [58e2672 kind: amend env variable CONFIG_WORKER_CPU_MANAGER](kubevirt/kubevirtci#983) [2957a2f publish: Refactor script](kubevirt/kubevirtci#980) ```release-note NONE ``` Signed-off-by: kubevirt-bot <[email protected]>
|
Hi, please see #1043 |
Note that it won't include the fix, as the SR-IOV lane is dedicated to SR-IOV, see please discussion in the mentioned PR. |
Currently, fix_node_labels is marking control-plane nodes as schedulable and removing the NoSchedule taint. Since these nodes are now behaving as worker nodes, they should also be given the worker node role.