kind: amend env variable CONFIG_WORKER_CPU_MANAGER

[zhlhahaha]

This variable is defined in cluster-up/cluster/kind/common.sh
which is CONFIG_WORKER_CPU_MANAGER rather than
CONFIG_CPU_MANAGER

[zhlhahaha]

cc: @oshoval

[brianmcarey]

Can you add the reason why this change is needed to the commit message?

[oshoval]

Thanks @zhlhahaha
Sorry that missed it, we don't maintain this provider so we don't have automation for it.
Also note that this provider can't stay 1.23, as we support only the last 3 k8s versions.
Every PR cause a presubmit and postsubmit, it might be possible to extract this provider outside of kubevirtci ?

Note that we might soon deprecate support of kind in favor for k3d,
would k3d be good enough for you in such case?

You can see the new k3d-1.25-sriov provider, where you can export DEPLOY_SRIOV=false in order to
deploy only k3d (EDIT note that it doesn't wait for the pods to be ready atm when SR-IOV is not deployed).

We strive to support less providers, as part of kubevirtci,
and only those which are relevant for the automation,
but of course we would like that it will be also comfortable for you.

PR desc / commit typo "varialbe"

[zhlhahaha]

Can you add the reason why this change is needed to the commit message?

Of course, this variable name supposed to be same as the following one, which make cpumanager related configuration would be set in kind.yaml for worker node.

kubevirtci/cluster-up/cluster/kind/common.sh

Line 10 in 2957a2f

CONFIG_WORKER_CPU_MANAGER=${CONFIG_WORKER_CPU_MANAGER:-false}

[zhlhahaha]

Thanks @zhlhahaha Sorry that missed it, we don't maintain this provider so we don't have automation for it.

I see, now we use this provider for e2e tests on Arm64 server.

Also note that this provider can't stay 1.23, as we support only the last 3 k8s versions.

Yes, you are right. I see the issue. for the cpumanager issue. I am curious why the issue occus.

Note that we might soon deprecate support of kind in favor for k3d, would k3d be good enough for you in such case?

I am not familiar with k3d. I may need to verify if it run well on Arm64 server and if it is suitable for CICD pipeline on Arm64.

You can see the new k3d-1.25-sriov provider, where you can export DEPLOY_SRIOV=false in order to deploy only k3d. We strive to support less providers.

Yes, it make sense.

[oshoval]

Can you add the reason why this change is needed to the commit message?

Of course, this variable name supposed to be same as the following one, which make cpumanager related configuration would be set in kind.yaml for worker node.

kubevirtci/cluster-up/cluster/kind/common.sh

Line 10 in 2957a2f

CONFIG_WORKER_CPU_MANAGER=${CONFIG_WORKER_CPU_MANAGER:-false}

Please add the explanation to the commit message / PR desc so we can merge this PR for now,
later on please let us know if k3d is suitable for you so we can drop this provider.
Is it fine ?

[zhlhahaha]

Please add the explanation to the commit message / PR desc so we can merge this PR for now,

Added

[oshoval]

Thanks, just a typo "varialbe" on PR desc and commit if you can take a look please

[oshoval]

Thanks

[brianmcarey]

/approve

[kubevirt-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: brianmcarey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [brianmcarey]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment